search

Isoldhe / Battleship

Battleship game in C#
0 stars 1 forks source link

Low level io #17

Closed Atrixsanna closed 5 years ago

Atrixsanna commented 5 years ago

Please take your time to comment on anything you think is weird or perhaps just interesting. I know this is a big pull request, that's because it overhauls most of the Console input and output.

The performance and possibilities should be close to perfect for game conditions now. I'm especially proud of smooth mouse input and color capabilities.

Also, this way of writing output data to the Console should also prevent any out-of-bounds crashes, even if the player goes wild with the screen dimensions.

Feel free to check out the low_level_io branch and try the look and feel with these changes.

Atrixsanna commented 5 years ago

closes #12 closes #3

Isoldhe commented 5 years ago

So uhm, this is all goes way over my head XD Just merge your pull request if you want to keep working on it. Maybe we can review it together sometime this week and you can explain the low level magic.

Atrixsanna commented 5 years ago

Hehehe, yeah it took me a few tries to get everything right myself.. Either way I appreciate you taking a moment to look at it. A colleague at work who does C++ told me that most of these low level functions are actually old C code, so its not just magic, its ancient magic. 🌠

I'll go ahead and merge this, but it may create some conflicts with your single_player_bot branch, due to the completely different approach for display. Just fyi I'm not planning any big structure or display overhauls like this anymore 😏, now its just feature after feature for the actual game. Either that or I'll post an issue and discuss it with you before I put in the work.