Isopolito / gNordVPN-Local

A Gnome extension that shows your VPN status and allows you to control the connection.
GNU General Public License v3.0
18 stars 12 forks source link

can't convert null to object #31

Closed mmuncan1980 closed 1 year ago

mmuncan1980 commented 2 years ago

i have tried several times to reinstall, system is fully up-to-date, Kali at the moment.

when i click on "on" it then says: "can't convert null to object" and doesnt start instead shows this error message.i dont know why this happens. please help! :D

Isopolito commented 2 years ago

Hi @mmuncan1980, I'll load up a Kali VM and investigate. What version of gnome are you using?

Tructruc commented 2 years ago

I have the same problem on pop os

Isopolito commented 2 years ago

@Tructruc what version of pop os and gnome are you running?

Tructruc commented 2 years ago

@Tructruc what version of pop os and gnome are you running?

Pop os 22.04, gnome 42.2

Isopolito commented 2 years ago

Interesting, Pop Os is my daily driver and I haven't seen that problem with those versions. I'll try to replicate it this week and get a fix out there. You installed it from the gnome extensions site?

Isopolito commented 2 years ago

image I'm running the above and things work fine. There's a bug where disabling the extension causes an error, but that's fixed in the version 13 (for gnome 43).

I'd be happy to help but will need more info to try to replicate the issue. The only idea I have is that there have been breaking changes between libsoup 2.x and 3. This shouldn't affect you because of the versions you're running, but just in case can you run apt list|grep libsoup and paste in the results?

ArthurMitchell42 commented 2 years ago

I'm also getting this and some other startup problems:

TypeError: can't convert null to object

Stack trace: buildPrefsWidget@/home/arthurm/.local/share/gnome-shell/extensions/gnordvpn-local@isopolito/prefs.js:105:33 _init@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:32:44 ExtensionPrefsDialog@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:10:4 OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:129:33 asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:115:22 run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:186:20 main@resource:///org/gnome/Shell/Extensions/js/main.js:22:13 run@resource:///org/gnome/gjs/modules/script/package.js:206:19 start@resource:///org/gnome/gjs/modules/script/package.js:190:8 @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

Isopolito commented 2 years ago

Hi @ArthurMitchell42 , the stack trace will be helpful thanks! Right now though I'm still trying to replicate this issue. Can you tell me:

  1. What version of the plugin you're using?
  2. Did you install from the gnome extensions site?
  3. What version of gnome are you are running?
  4. What OS and version number of it you're using?

I'll get it fixed once I can replicate.Appreciate it!

Isopolito commented 2 years ago

More questions....What's going on when the error occurs? For instance, do you happen to not have an internet connection when the error shows up?

ArthurMitchell42 commented 2 years ago

image Hi, I'm using the one on gnome extension, I think it's 11? I've attached a shot. This is running on Ubuntu 22.04 LTS using Wayland and gnome 42.4

The extension was working well but now this happens after boot and the internet/network is connected. I can't trace to an indecent when the failure started but I got an update on Thursday and it might have been after that. I did have occasion issues with other errors before mind you. I've also tried reboots, log out & in. I also removed it and reinstalled from the extension page using the browser plug in as usual and it still has the same error. I'm happy to provide any more investigation if you need. Arthur

Isopolito commented 2 years ago

Thanks very much @ArthurMitchell42, I'll get a VM set up to match what you have and see if I can replicate it.

ArthurMitchell42 commented 2 years ago

Thanks, let me know if you need me to do anything from my end.

ArthurMitchell42 commented 2 years ago

Hi, do you need any further investigation work please? Is there any light at the end of the tunnel? Regards, A

Isopolito commented 2 years ago

Hi @ArthurMitchell42, I was unable to replicate this and have been slammed at work so haven't been able to circle back to it. If I could reproduce this issue I would able to fix it...One thing you can try is to manually remove it and reinstall it. This document outlines how to do it: https://www.debugpoint.com/manual-installation-gnome-extension/

Just remember to delete the existing gnordvpn folder that's installed first. You can download the zip file from gnome extension site, you'll want the one for version gnome 42: image

Please let me know how that goes, apologies for any inconvenience you're having. It's important to me to get these issues resolved.

ArthurMitchell42 commented 2 years ago

Hi there, well the good news is it's working now, the part I can't explain is why. I've been through uninstalling and re-installing, also trying the ZIP from GitHub directly. No luck. I checked the NordVPN just to make sure it was ok and it confirmed I was logged in and it then connected fine. Just out of curiosity/desperation I re-installed the NordVPN from the .deb (despite it still working) and it all sprang back into life. I can't explain what was resolved but something was obviously missing/corrupt and now is fixed. Sorry to have bothered you but I can't explain this at all. :) Thanks for your support though.

Isopolito commented 2 years ago

Hi @ArthurMitchell42, it was no bother at all. I'm just glad it's working for you now. In fact, you reminded me that there is an outstanding issue I intend to fix. I want to investigate it a bit more and then make an issue for it. But essentially I've seen the extension crash and burn when NordVPN is not working or is not installed. The extension should gracefully handle that situation but currently doesn't.

@mmuncan1980 and @Tructruc: by chance is there a problem with your nordVPN (or is it not installed) when are you having the issues you reported?

Jesse-Millwood commented 2 years ago

for what it's worth, I just signed up for nord VPN today and installed the deb today. I'm on Pop OS and have the same issue as @ArthurMitchell42

OS Version: Pop!_OS 22.04 (fully updated) Gnome Version: 42.4 Installed from the gnome extension site I believe the version of the plugin is 11.

Isopolito commented 2 years ago

@Jesse-Millwood, the issue being trying to use the extension before NordVPN is up and running properly?

Jesse-Millwood commented 2 years ago

@Jesse-Millwood, the issue being trying to use the extension before NordVPN is up and running properly?

I logged in via the command line using the token and used the command line tool to connect. I did verify that I was connected with some websites that showed that the VPN was working

Isopolito commented 2 years ago

@Jesse-Millwood Ok so even with the active vpn connection you're still getting that "can't convert null to object" error?

Jesse-Millwood commented 2 years ago

@Jesse-Millwood Ok so even with the active vpn connection you're still getting that "can't convert null to object" error?

That's correct. I uninstalled the plugin through the gnome extensions site. Then I disconnected and reconnected to nord VPN through the command line utility. I then tried to install the plug-in again and received the same error message.

Isopolito commented 2 years ago

@Jesse-Millwood Thanks

Jesse-Millwood commented 2 years ago

@Isopolito I actually restarted my computer and the extension seems to be working now!

Isopolito commented 2 years ago

@Jesse-Millwood Weird lol. Glad it's working now for you though. Eventually I'll get to the bottom of this. Thanks for your input, it all helps me circle closer to the problem

ArthurMitchell42 commented 2 years ago

Hmmm, I'm not at all sure what's happening. I rebooted today and although the extension seems to be working the extension manager shows this: nordvpn_error If I click settings it doesn't give me a stack trace but opens the settings as normal?

Isopolito commented 2 years ago

Hi @ArthurMitchell42, that's a known issue that is fixed in the newest version (for gnome 43). It doesn't actually cause any problems, other then you can't disable the extension :)

ArthurMitchell42 commented 2 years ago

That's good, I'll ignore it thanks

Isopolito commented 1 year ago

Releasing a new version that will address these issues today, thanks for the feedback everyone!