search

Isopolito / gNordVPN-Local

A Gnome extension that shows your VPN status and allows you to control the connection.
GNU General Public License v3.0
18 stars 12 forks source link

Disable extension is not working for gnome 43 #33

Closed makarov-roman closed 2 years ago

makarov-roman commented 2 years ago

Describe the bug When I tried to disable extension via Extensions app it showed following error: this._commonFavorite.disable is not a function

To Reproduce Steps to reproduce the behavior:

  1. Go to Extensions app
  2. Click on 'on/off switch'
  3. See error

Expected behavior Extension is disabled

Screenshots image

Desktop (please complete the following information):

Additional context Gnome Extensions version: 43~beta from fedora repo. I don't know how are pipelines for plugin release working, but the latest available version at gnome-extensions is 11 (should be 12).

Isopolito commented 2 years ago

Hi @makarov-roman, thanks for the heads up on this and the details you provided. Looking into it now, still haven't released version 12 to gnome extensions because I need to get a VM with gnome 43 loaded up to test

Isopolito commented 2 years ago

@makarov-roman I can reproduce the error, going to get a fix out next week and will release version 12 of the extension

Isopolito commented 2 years ago

@makarov-roman Disable bug fixed (and version bumped to work with gnome 43). Extension submitted for release.

Thanks so much for bringing this to my attention, cheers