search

IsraelHikingMap / Site

Israel Hiking Map has maps, route planning, and travel information for Israel. This repository holds the files needed for running the Israel Hiking Map site and apps.
https://israelhiking.osm.org.il/
Other
81 stars 33 forks source link

Duplicate IDs when getting data from database #1247

Closed HarelM closed 4 years ago

HarelM commented 4 years ago

Bug

When querying the elastic database sometimes the deserialized objects have the same id in the properties table. Long discussion can be seen here: https://github.com/NetTopologySuite/NetTopologySuite.IO.GeoJSON/issues/46

This was emphasized after the implementation of rebuild POIs every hour: #1169

Next steps:

  1. Use Stream instead of deserializing using elastic infra and see if the issue reproduces, if so, dump the text to file. https://stackoverflow.com/questions/26753277/how-can-i-pass-through-the-raw-json-response-from-a-nest-elasticsearch-query

  2. If this doesn't help maybe there will be a need to write a custom serializer to handle this...

HarelM commented 4 years ago

Opened an issue for elasticsearch as well: https://github.com/elastic/elasticsearch-net/issues/4791