Allow add a gate when no highways are around

IsraelHikingMap / Site

Israel Hiking Map has maps, route planning, and travel information for Israel. This repository holds the files needed for running the Israel Hiking Map site and apps.

https://israelhiking.osm.org.il/

Other

82 stars 33 forks source link

Allow add a gate when no highways are around #1478

Closed zstadler closed 3 years ago

zstadler commented 3 years ago

Bug

What I expect to happen

See an error message when a barrier POI cannot be created

What really happened

Received a confirmation message

What I did that caused the issue - step by step

There are several senaries where a barrier cannot be created. Here is an unrealistic example for simplicity.

Create a private POI at sea, away from the shore
Upload the POI as a closed gate
Receive a confirmation message

HarelM commented 3 years ago

This also causes the queue to get stuck... Related to #1477

HarelM commented 3 years ago

Causing the queue to get stuck will be solved in #1477, UX of error when uploading a POI will be handled here. Reducing severity.

HarelM commented 3 years ago

@zstadler I can't think of a good UX to solve this... :-( The only idea I have is to change the message text to something like "thanks for contributing, the data will be checked and uploaded if it's valid" and change the toast color from green to black. The upload may happen instantly or after a few hours depending on the internet connecting so popping up a message according to response from server doesn't feel like a solution for me. Allowing the user to somehow amend his upload in case of a problem is a huge effort with little value as I think this can happen only to gates right now... If you have an idea for a solution please let me know...

zstadler commented 3 years ago

MHO, from a UX perspective,

If the upload and OSM update are successful on the first attempt, which is probably the majority of interactions, the message is better left unchanged.
If the first attempt is not successful, the message may also include that fact: "Thanks! Your contribution will be uploaded and validated as soon as possible."
I believe the user cares about the eventual response from the server, for better or worse.
- A negative acknowledge is important even if there is nothing the application can do about it.
Perhaps the way to present failures is by adding a new "upload errors" private route. Each point would be at the location of the failed POI upload. The details of the intended upload and the error will be in the description.

In the above proposal I also considered the potential need to handle errors in other types of uploads, not only barriers, given the offline-first approach.

HarelM commented 3 years ago

While it's possible and I think it's s good way to show these errors, it would require a lot of effort with very limited value. I would like to try and think about a far less complex implantation to solve this. I'll mark this issue as "need discussion" and we'll take this offline. As to other uploads, currently all know limitations are handled in the client side so in theory, besides gates, upload should not fail.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days

zstadler commented 3 years ago

Discussion summary

As far as we know, barrier POIs are not inserted only when a highway way cannot be found within the search radius. In this case, rather than not inserting the barrier, it should be inserted at the report location, disconnected from any OSM way. This operation is no different than a similar operation using an OSM editor. As a result, there is no loss of an edit and no need to inform the user of a failure to insert a barrier.