IsraelHikingMap / Site

Israel Hiking Map has maps, route planning, and travel information for Israel. This repository holds the files needed for running the Israel Hiking Map site and apps.
https://israelhiking.osm.org.il/
Other
80 stars 32 forks source link

[iOS] Can't open file with ":" in its name #1751

Closed doronkeren closed 2 years ago

doronkeren commented 2 years ago

Bug

What I expect to happen

iphone app should read the gpx file

What really happened

error "לא ניתן למצוא מידע גיאוגרפי בקובץ"

What I did that caused the issue - step by step

  1. export gpx file from iphone health db to icloud using "gpx" app from the app stoe
  2. select the gpx file in the iphone files app3
  3. share the file to israelhiking map app

-- other iphone apps (like Outdooractive) read the file isralehikingmap web page on macos safari reads the file

My environment

ios 16 (beta) israelhikingmap v9.14.2

Things I think the developers should know, images, links etc.

Hi Steed & co.

gpx file attached as .txt file (since this github page does not allow uploading .gpx files), to reproduce rename to .gpx

2022-08-23T14:59:38Z copy.gpx.txt

HarelM commented 2 years ago

Thanks for taking the time to report this issue! Can you share some screen shot on what operations you did out side Israel Hiking app? i.e. which applications did you use, what did you press there, did you share the file with the app or did you open the file from the app "open files" menu? It's very important for us to understand what operations you did. Also please report an issue with the app and send it to us or attach the log file that the app generates to this issue, which every is simpler for you.

doronkeren commented 2 years ago

Hi,

Here is a step by step 'how to reproduce'

  1. save the attached file to an icloud storage
  2. change the file extension to .gpx
  3. open 'files' ios app on an iphone with access to the icloud storage
  4. select the .gpx file
  5. click the 'share' icone
  6. from the share to application list, select 'israelhikingmap'. you may need to click the ... button to find it

the log files contains personal info, i will not send it at this point

HarelM commented 2 years ago

I followed the steps on my iPad (running iOS 15.6) but was unable to reproduce this:

  1. Using my browser on my mac desktop I downloaded the txt file
  2. Changed its name to "bug.gpx"
  3. Uploaded to iCould
  4. Using the iPad I made sure the file is there using the files app
  5. Long pressed the file and seleted Share
  6. Selected IHM

The file was presented and no error message was seen. Can you check if you change the file name it solves this issue as I don't see any other difference between what you did and what I did, besides maybe the fact that you are using iOS 16 which is in beta and might cause this, IDK...

HarelM commented 2 years ago

I also tried with the original name and it worked. The only thing I can think of is iOS 16 at this moment. If not sending the full log it will help us if you could extract the relevant lines maybe? Log lines with [Open With] and maybe an error message after that...? Without a way to reproduce it and without the logs there is no way for me to fix this issue...

doronkeren commented 2 years ago

Renaming to bug.gpx loaded ok the original file name (gps\ files/biking/2022-08-23T14:59:38Z.gpx) produced an error

Here are the relevant lines from the log file:

2022-08-30 16:48:39 | INFO | --- Reporting an issue --- 2022-08-30 16:48:35 | INFO | [Screen] Setting mode: screen-on 2022-08-30 16:48:35 | INFO | [Screen] App is active, watching idle and setting screen mode 2022-08-30 16:48:34 | ERROR | לא ניתן למצוא מידע גיאוגרפי בקובץ...: ENCODING_ERR 2022-08-30 16:48:34 | INFO | [OpenWith] Opening a file shared with the app file:///private/var/mobile/Containers/Data/Application/1FC5990B-9B54-4B52-8851-286E5225CFED/tmp/il.org.osm.israelhiking-Inbox/2022-08-23T14:59:38Z.gpx 2022-08-30 16:48:15 | INFO | [Screen] App is inactive, stop watching idle setting brightness to original: 0.75 2022-08-30 16:48:07 | INFO | [Screen] Setting mode: screen-on 2022-08-30 16:48:07 | INFO | [Screen] App is active, watching idle and setting screen mode 2022-08-30 16:48:07 | ERROR | לא ניתן למצוא מידע גיאוגרפי בקובץ...: ENCODING_ERR 2022-08-30 16:48:07 | INFO | [OpenWith] Opening a file shared with the app file:///private/var/mobile/Containers/Data/Application/1FC5990B-9B54-4B52-8851-286E5225CFED/tmp/il.org.osm.israelhiking-Inbox/2022-08-23T14:59:38Z.gpx 2022-08-30 16:44:51 | INFO | [Screen] App is inactive, stop watching idle setting brightness to original: 0.75 2022-08-30 16:44:50 | INFO | [Screen] Setting mode: screen-on 2022-08-30 16:44:50 | INFO | [Screen] App is active, watching idle and setting screen mode 2022-08-30 16:44:50 | ERROR | לא ניתן למצוא מידע גיאוגרפי בקובץ...: ENCODING_ERR 2022-08-30 16:44:50 | INFO | [OpenWith] Opening a file shared with the app file:///private/var/mobile/Containers/Data/Application/1FC5990B-9B54-4B52-8851-286E5225CFED/tmp/il.org.osm.israelhiking-Inbox/2022-08-23T14:59:38Z.gpx 2022-08-30 16:44:35 | INFO | [Screen] App is inactive, stop watching idle setting brightness to original: 0.75 2022-08-30 16:44:31 | INFO | [Screen] Setting mode: screen-on 2022-08-30 16:44:31 | INFO | [Screen] App is active, watching idle and setting screen mode 2022-08-30 16:44:31 | INFO | [OpenWith] Opening a file shared with the app file:///private/var/mobile/Containers/Data/Application/1FC5990B-9B54-4B52-8851-286E5225CFED/tmp/il.org.osm.israelhiking-Inbox/bug.gpx Doron

On Tue, Aug 30, 2022 at 3:37 PM Harel M @.***> wrote:

I also tried with the original name and it worked. The only thing I can think of is iOS 16 at this moment. If not sending the full log it will help us if you could extract the relevant lines maybe? Log lines with [Open With] and maybe an error message after that...? Without a way to reproduce it and without the logs there is no way for me to fix this issue...

— Reply to this email directly, view it on GitHub https://github.com/IsraelHikingMap/Site/issues/1751#issuecomment-1231608358, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRJHHB27DCOKPJONBZLSF3V3X6AJANCNFSM5742WMLQ . You are receiving this because you were assigned.Message ID: @.***>

doronkeren commented 2 years ago

sharing directly from the gpx app resulted in the same error

2022-08-30 16:58:04 | INFO | --- Reporting an issue --- 2022-08-30 16:57:52 | INFO | [Screen] Setting mode: screen-on 2022-08-30 16:57:52 | INFO | [Screen] App is active, watching idle and setting screen mode 2022-08-30 16:57:52 | ERROR | לא ניתן למצוא מידע גיאוגרפי בקובץ...: ENCODING_ERR 2022-08-30 16:57:52 | INFO | [OpenWith] Opening a file shared with the app file:///private/var/mobile/Containers/Data/Application/1FC5990B-9B54-4B52-8851-286E5225CFED/Documents/Inbox/2022-08-27T14:09:48Z.gpx

Doron

On Tue, Aug 30, 2022 at 4:54 PM Doron Keren @.***> wrote:

Doron

On Tue, Aug 30, 2022 at 4:52 PM Doron Keren @.***> wrote:

Renaming to bug.gpx loaded ok the original file name (gps\ files/biking/2022-08-23T14:59:38Z.gpx) produced an error

Here are the relevant lines from the log file:

2022-08-30 16:48:39 | INFO | --- Reporting an issue --- 2022-08-30 16:48:35 | INFO | [Screen] Setting mode: screen-on 2022-08-30 16:48:35 | INFO | [Screen] App is active, watching idle and setting screen mode 2022-08-30 16:48:34 | ERROR | לא ניתן למצוא מידע גיאוגרפי בקובץ...: ENCODING_ERR 2022-08-30 16:48:34 | INFO | [OpenWith] Opening a file shared with the app file:///private/var/mobile/Containers/Data/Application/1FC5990B-9B54-4B52-8851-286E5225CFED/tmp/il.org.osm.israelhiking-Inbox/2022-08-23T14:59:38Z.gpx 2022-08-30 16:48:15 | INFO | [Screen] App is inactive, stop watching idle setting brightness to original: 0.75 2022-08-30 16:48:07 | INFO | [Screen] Setting mode: screen-on 2022-08-30 16:48:07 | INFO | [Screen] App is active, watching idle and setting screen mode 2022-08-30 16:48:07 | ERROR | לא ניתן למצוא מידע גיאוגרפי בקובץ...: ENCODING_ERR 2022-08-30 16:48:07 | INFO | [OpenWith] Opening a file shared with the app file:///private/var/mobile/Containers/Data/Application/1FC5990B-9B54-4B52-8851-286E5225CFED/tmp/il.org.osm.israelhiking-Inbox/2022-08-23T14:59:38Z.gpx 2022-08-30 16:44:51 | INFO | [Screen] App is inactive, stop watching idle setting brightness to original: 0.75 2022-08-30 16:44:50 | INFO | [Screen] Setting mode: screen-on 2022-08-30 16:44:50 | INFO | [Screen] App is active, watching idle and setting screen mode 2022-08-30 16:44:50 | ERROR | לא ניתן למצוא מידע גיאוגרפי בקובץ...: ENCODING_ERR 2022-08-30 16:44:50 | INFO | [OpenWith] Opening a file shared with the app file:///private/var/mobile/Containers/Data/Application/1FC5990B-9B54-4B52-8851-286E5225CFED/tmp/il.org.osm.israelhiking-Inbox/2022-08-23T14:59:38Z.gpx 2022-08-30 16:44:35 | INFO | [Screen] App is inactive, stop watching idle setting brightness to original: 0.75 2022-08-30 16:44:31 | INFO | [Screen] Setting mode: screen-on 2022-08-30 16:44:31 | INFO | [Screen] App is active, watching idle and setting screen mode 2022-08-30 16:44:31 | INFO | [OpenWith] Opening a file shared with the app file:///private/var/mobile/Containers/Data/Application/1FC5990B-9B54-4B52-8851-286E5225CFED/tmp/il.org.osm.israelhiking-Inbox/bug.gpx Doron

On Tue, Aug 30, 2022 at 3:37 PM Harel M @.***> wrote:

I also tried with the original name and it worked. The only thing I can think of is iOS 16 at this moment. If not sending the full log it will help us if you could extract the relevant lines maybe? Log lines with [Open With] and maybe an error message after that...? Without a way to reproduce it and without the logs there is no way for me to fix this issue...

— Reply to this email directly, view it on GitHub https://github.com/IsraelHikingMap/Site/issues/1751#issuecomment-1231608358, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRJHHB27DCOKPJONBZLSF3V3X6AJANCNFSM5742WMLQ . You are receiving this because you were assigned.Message ID: @.***>

HarelM commented 2 years ago

Strange, not sure what encoding error means and why it helps changing the file name helps but it looks like file name issue, not sure I can fix that though... I'll try to reproduce again... Is the file inside a folder?

doronkeren commented 2 years ago

Doron

On Tue, Aug 30, 2022 at 5:50 PM Harel M @.***> wrote:

Strange, not sure what encoding error means and why it helps changing the file name helps but it looks like file name issue, not sure I can fix that though... I'll try to reproduce again... Is the file inside a folder?

what do you mean? every file is in a folder

— Reply to this email directly, view it on GitHub https://github.com/IsraelHikingMap/Site/issues/1751#issuecomment-1231776740, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRJHHAR7WPERBWPBDZEKRDV3YNSZANCNFSM5742WMLQ . You are receiving this because you were assigned.Message ID: @.***>

HarelM commented 2 years ago

Are you using the documents folder and keep the files there or are you using a sub folder? If a sub folder under documents, then what's the folder(s) name(s)? As I said, I'm unable to reproduce this locally so I must be doing something different than you do. Which app are you using to share the gpx from?

doronkeren commented 2 years ago

This is the app

https://apps.apple.com/app/id1487816558

I saved the file to an icloud folder

On Thu, 1 Sep 2022 at 18:27 Harel M @.***> wrote:

Are you using the documents folder and keep the files there or are you using a sub folder? If a sub folder under documents, then what's the folder(s) name(s)? As I said, I'm unable to reproduce this locally so I must be doing something different than you do. Which app are you using to share the gpx from?

— Reply to this email directly, view it on GitHub https://github.com/IsraelHikingMap/Site/issues/1751#issuecomment-1234439417, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRJHHD7FSNNTAK4K5Y44JTV4DDPXANCNFSM5742WMLQ . You are receiving this because you were assigned.Message ID: @.***>

--

  • Doron
HarelM commented 2 years ago

Hi Doron, I tired again today and it seems that I can't create a file name with ":" no matter how hard I try. If I download the file here from github it replaces ":" with ".". If I try to change the name manually on my iPad I get an error saying I can't use ":". So the bottom line is that apparently the app you are using (which I can't install on my iPad since it's not supported there) is creating invalid file names. I suggest to talk to their support, I don't know how safari or chrome are being able to open the file and how the app created an invalid file name...

doronkeren commented 2 years ago

There is no problem loading the file to other map apps like outdooractive https://apps.apple.com/il/app/outdooractive-hiking-cycling/id1364846172, offroad, guru maps

I will try to send a note to the gpx app developer.

Thank for the effort!

On Sun, 4 Sep 2022 at 21:45 Harel M @.***> wrote:

Hi Doron, I tired again today and it seems that I can't create a file name with ":" no matter how hard I try. If I download the file here from github it replaces ":" with ".". If I try to change the name manually on my iPad I get an error saying I can't use ":". So the bottom line is that apparently the app you are using (which I can't install on my iPad since it's not supported there) is creating invalid file names. I suggest to talk to their support, I don't know how safari or chrome are being able to open the file and how the app created an invalid file name...

— Reply to this email directly, view it on GitHub https://github.com/IsraelHikingMap/Site/issues/1751#issuecomment-1236394808, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRJHHF5W4F6KSAOP2GX55DV4TU5XANCNFSM5742WMLQ . You are receiving this because you were assigned.Message ID: @.***>

--

  • Doron
HarelM commented 2 years ago

Since there are multiple workarounds (remane file, open in browser, etc) and this seems to be an issue with a specific app that creates invalid file names (since they can be created manually), and since fixing this requires to dig deep into cordova side to understand why this file name can't be opened, I have decided to close this issue as it has very low ROI. Feel free to continue posting here or in any other place for further support :-)