search

IsraelHikingMap / Site

Israel Hiking Map has maps, route planning, and travel information for Israel. This repository holds the files needed for running the Israel Hiking Map site and apps.
https://israelhiking.osm.org.il/
Other
83 stars 33 forks source link

Move to STJ #1837

Closed HarelM closed 1 year ago

HarelM commented 1 year ago

What is the problem this feature will solve?

Moving to STJ might improve the site's performance and reduce dependencies

What is the feature you are proposing to solve the problem?

Infta change

What alternatives have you considered or tried?

Keep the current state

Additional information

No response

HarelM commented 1 year ago

Some links to things that should just work, but don't: https://github.com/dotnet/runtime/issues/1566 https://github.com/NetTopologySuite/NetTopologySuite.IO.GeoJSON/issues/44 https://github.com/NetTopologySuite/NetTopologySuite.IO.GeoJSON/issues/117

Current status: The build is not failing, but there are a lot of runtime issues due to changes in deserialization...

Things to test and fix:

  1. ~Elastic wrapper in general with IFeature stuff~
  2. Imgur was changed and not tested
  3. ~Return dates from API~
  4. ~Make sure es 8 code is the same for the json serializer~
  5. ~Can't update attributes table ATM~
  6. Need to remove temporary NTS feed and use a properly released version
  7. Need to see that the CI passes when using the hourly rebuild
  8. ~poiId field is used for identification, I was thinking about using the geojson id field like in the spec, but it seems that there's a problem when it comes to MVT, as MVT doesn't support it and so when creating tiles from features that doesn't have an id field in the properties it breaks... :-(~ Decided to forfeit this ATM.
HarelM commented 1 year ago

There is an issue with the OSM id that is used as string in the server side and as number in the client side. Newtonsoft was able to handle this gracefully but STJ fails. This is currently in ShareUrl and MapLayerData POCOs. https://stackoverflow.com/questions/59097784/system-text-json-deserialize-json-with-automatic-casting

HarelM commented 1 year ago

This was solved by last commit b3e8144ded186e0b7c5847c79fa8cc5336a4af47. I haven't seen any other issues lately. If new issues arise I will open different issues and solve them as they come.