IsraelHikingMap / Site

Israel Hiking Map has maps, route planning, and travel information for Israel. This repository holds the files needed for running the Israel Hiking Map site and apps.
https://israelhiking.osm.org.il/
Other
77 stars 31 forks source link

Car/4WD does not pass through gate w/o any restrictions #185

Closed zstadler closed 7 years ago

zstadler commented 7 years ago

This is no appropriate for Israel where may villages have an entrance gate.

For example, the entry to Almagor - http://israelhiking.osm.org.il/#/?s=aUhQ0SBk9d

HarelM commented 7 years ago

I think we should better define gates before fixing this routing issue as some gates can't be driven through. Also in this case I think there should be a routing issue so that you'll know there's a gate there that might be closed... You can also switch to None-routing for this leg. I don't think this bug should have high priority...

zstadler commented 7 years ago

The gates are well classified. A gate provides access unless it has an access restriction, such as access=no and motor_vehicle=no.

We also map the gates accordingly:

That's why I think this is a high priority issue.

HarelM commented 7 years ago

Let's see what the guys at GH answer first...

karussell commented 7 years ago

@zstadler why do you think it is 'well classified' - do you have link to the wiki? I have interpreted the defaults as access=no, especially for gate

HarelM commented 7 years ago

One could argue that in order to prevent access you'll need to add a tag to the element restricting access otherwise there is no restriction. The wiki of both gate and access are not defining the default though.

zstadler commented 7 years ago

I don't see why a barrier=gate with no access tag would allow bicycle or foot access but not for cars. Unlike a cycle_barrier or a stile, there is nothing in a gate's structure that is specifically built to restrict or allow a certain type of access.

zstadler commented 7 years ago

See new comment on Routing through gates that don't have restrictions for car profile graphhopper/graphhopper#754

HarelM commented 7 years ago

See relevant check-ins, pull request and forked repository.