search

IsraelHikingMap / Site

Israel Hiking Map has maps, route planning, and travel information for Israel. This repository holds the files needed for running the Israel Hiking Map site and apps.
https://israelhiking.osm.org.il/
Other
76 stars 31 forks source link

Simplify connection service #1954

Closed HarelM closed 6 months ago

HarelM commented 6 months ago

There are weird behaviors when it comes to the connection service, I want to see if this help in reducing the problem with streams that are ending etc. I don't know if this will solve the issue as I can't reproduce this easily. The issue is that sometimes when the app is running for a long time, the connection service is reporting the wrong state...

The only thing I found to solve this is to restart the app... :-/

CLAassistant commented 6 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4e44d8d) 91.93% compared to head (0fedc2d) 91.93%.

:exclamation: Current head 0fedc2d differs from pull request most recent head 04676ec. Consider uploading reports for the commit 04676ec to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1954 +/- ## ======================================= Coverage 91.93% 91.93% ======================================= Files 91 91 Lines 6743 6743 Branches 984 984 ======================================= Hits 6199 6199 Misses 340 340 Partials 204 204 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.