search

IsraelHikingMap / Site

Israel Hiking Map has maps, route planning, and travel information for Israel. This repository holds the files needed for running the Israel Hiking Map site and apps.
https://israelhiking.osm.org.il/
Other
76 stars 31 forks source link

Remove patch-package for capacitor-android #1965

Closed HarelM closed 4 months ago

HarelM commented 4 months ago

What is the problem this feature will solve?

I need to update the patched package every time I upgrade a version of capacitor android. This patch is solving the following bug:

What is the feature you are proposing to solve the problem?

According to the following rejected pull request response: https://github.com/ionic-team/capacitor/pull/7194 The proposal is to override the onShowFileChooser method.

What alternatives have you considered or tried?

The above PR comment also suggests creating a plugin, but this seems like an overkill for this.

Additional information

The above PR was trying to solve the following issues: https://github.com/ionic-team/capacitor/issues/7220 https://github.com/ionic-team/capacitor/issues/6943 And the response to it suggested to open an issue for google, which I opened here: https://issuetracker.google.com/issues/322839802

As a side note, @jcesarmobile, locking a conversation is not very welcoming, when all I'm trying to do is help solving a bug.

jcesarmobile commented 4 months ago

Please, can you not harass me?

HarelM commented 4 months ago

Can we please keep it professional? I'm not harassing anyone.