search

IsraelHikingMap / Site

Israel Hiking Map has maps, route planning, and travel information for Israel. This repository holds the files needed for running the Israel Hiking Map site and apps.
https://israelhiking.osm.org.il/
Other
76 stars 31 forks source link

Can't download offline files #1993

Closed HarelM closed 2 weeks ago

HarelM commented 4 weeks ago

What happened?

Application fails to download offline files

What steps will reproduce the bug?

  1. Start offline files download
  2. Fails after 50%

What I expect to happen

Download should succeed

Platform

OS Name and Version

Android 13

Browser Name and Version

N/A

Additional information

This is related to a recent change I made when migrating to github actions where I added magnification and proguard to android build.

The reason I added it was to solve I warning I keep getting when publishing the aab file in play console. There is cause a runtime issue that is described here:

There are two options here:

  1. Revert changes (which I checked to make sure it solves the issue) and keep the play console warning
  2. Add proguard rules to avoid minify cordova and capacitor plugins and core, the problem with this approach is that the issues we encountered are runtime exceptions, and those are hard to predict and test up front before publishing the app.

Both options aren't great...

HarelM commented 2 weeks ago

I have decided to revert as an initial step, I'll later on see if the warnings are still in the play console and see what's the easiest way to fix them.