IsraelHikingMap / Site

Israel Hiking Map has maps, route planning, and travel information for Israel. This repository holds the files needed for running the Israel Hiking Map site and apps.
https://israelhiking.osm.org.il/
Other
84 stars 33 forks source link

Fix modal height - Increase Css specificity #2039

Closed MAvaisAshraf closed 1 month ago

MAvaisAshraf commented 1 month ago

checked the issue we used class and due to low specificity this code was not overwriting, I have increased Specificity by adding !important;

CLAassistant commented 1 month ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: MAvaisAshraf
:x: HarelM
You have signed the CLA already but the status is still pending? Let us recheck it.

HarelM commented 1 month ago

Can you please resolve the conflict? Also can you use height < ... Instead of max-height (similar to the other media query)?

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.33%. Comparing base (9ed2026) to head (ee36417).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2039 +/- ## ======================================= Coverage 91.33% 91.33% ======================================= Files 93 93 Lines 8103 8103 Branches 985 985 ======================================= Hits 7401 7401 Misses 477 477 Partials 225 225 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MAvaisAshraf commented 1 month ago

Resolved Conflict and changed max-height to height <= as requested in the media query.

HarelM commented 1 month ago

Thanks! can you please share a screenshot of how this looks after the fix?

MAvaisAshraf commented 1 month ago

note: Add dummy text just for screenshots to increase modal height to see the scroll effect. modal-horizontal modal-vertical