IsraelHikingMap / Site

Israel Hiking Map has maps, route planning, and travel information for Israel. This repository holds the files needed for running the Israel Hiking Map site and apps.
https://israelhiking.osm.org.il/
Other
84 stars 33 forks source link

Improve attribution protection for images #2072

Closed HarelM closed 2 weeks ago

HarelM commented 2 weeks ago

Related to:

Checks the attribution in parallel for all images when converting the data of a POI to be presented. The attribution is cached, so this should not impact performance much. Filter out images that do not have the relevant attribution. Changed the attribution fetching to use Wikimedia commons instead of a specific language for wikipedia, this way the mechanism is more robust and doesn't require to check the user's current language.

CLAassistant commented 2 weeks ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: zstadler
:x: HarelM
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov-commenter commented 2 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.43%. Comparing base (63508db) to head (8ef4f25).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2072 +/- ## ======================================= Coverage 90.43% 90.43% ======================================= Files 100 100 Lines 8518 8520 +2 Branches 1071 1070 -1 ======================================= + Hits 7703 7705 +2 Misses 586 586 Partials 229 229 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.