IsraelHikingMap / VectorMap

Vector Maps for the Israel Hiking and Biking Maps
Other
10 stars 6 forks source link

In cycling map, do not show non existing cycling lanes around paths #148

Closed Tsurha closed 1 year ago

Tsurha commented 1 year ago

For example here: https://israelhiking.osm.org.il/map/18.65/32.1168/34.8258

Cycling is allowed there, but there are no real cycling lanes.

image

zstadler commented 1 year ago

I'm confused. I thought that cycleway=track means that there is a cycling lane. For example, https://www.openstreetmap.org/way/174274992

Tsurha commented 1 year ago

Seems like at the above point we have two issues: a) the tagging is wrong in OSM (as there are no cycling path on either side of Pinhas Rosen there. b) the rendering to IHM cycling is wrong. It shows a cycling lane to both the left and the right of that Path. The result is 4 cycling lanes around Pinhas Rosen...

Here is a different rendering issue example: https://israelhiking.osm.org.il/map/19.02/32.0987/34.7830 At the 2 points I circled, a lane exists but the map shows 3 cycling lanes in each. Instead of just the middle one, two are added to its right and left.
image

zstadler commented 1 year ago

There are two topics that need to be considered separately:

  1. Is the OSM tagging appropriate for the facts on the ground?
  2. What is the appropriate rendering of a the OSM tagging?

In Add support for cycle lanes and tracks via the cycleway key #61 @nonZero wrote:

Regarding rendering: For cycling maps the whole road/way could be rendered as "cycling friendly", while ignoring the left/right rendering.

In all cases presented in this issue, the ways were tagged with cycleway=track and rendered according to the above. If there needs to be a change/refinement of this request, please agree on a new requirement.

Tsurha commented 1 year ago

I started fixing OSM tags in the above cases. Waiting to see the new IHM rendering but that takes long or may be off right now.

I also see that the ID editor recommends to remove the cycleway=track tag when its together with highway=cycleway. I'm waiting to see if it solves the 3 lines near Even Gvirol

removal of cycleway track suggested

Tsurha commented 1 year ago

Where I fixed manually, the three lines are thankfully gone.

However there are more I saw by just browsing and probable many more I didn't see. A few examples: https://israelhiking.osm.org.il/map/20.58/32.0800/34.7843 https://israelhiking.osm.org.il/map/21.29/32.0593/34.7791 https://israelhiking.osm.org.il/map/21.29/32.0586/34.7785 https://israelhiking.osm.org.il/map/21.24/32.1005/34.7973

Could you not render additional cycling lines to the right and left of highway= cycleway, footway, pedestrian, path... ? Alternatively find all of them in Israel to see if it better to manually fix?

Personally after the above-mentioned #61 fix I'm less confident a cycling path exists around all the roads that it is attached to, besides in Modi'in :-)

zstadler commented 1 year ago

In general, tagging errors should be fixed at the source rather than hidden by the renderer.

This query finds all highway=cycleway/footway/pedestrian/path with cycleway=track in Israel. There are 27 of them, all but 3 are in the Tel-Aviv area.

image

It would be best to check the facts on the ground and correct the tagging where needed.

Tsurha commented 1 year ago

Thank you for the query. I fixed all those instances so now just one cycling path is presented.
Apparently I should have also specified cycleway=lane and the above four. So used your query with that too.
For now I think this is it.

zstadler commented 1 year ago

Excellent! If this issue is no longer applicable, please close it.