Closed lioreshai closed 6 years ago
I really like this improvement. Will have it into account, package is currently being entirely rewritten :)
Sounds good I'm looking forward to it. Happy to contribute to the rewritten package as well.
I will leave it open as I like it and do not want to forget
Defining a call method in the trait opens up the application to the possibility of conflicts. If any other trait wants to use the call method, the a fatal error is fired due to collision.
I think it would be better to override __call in the model using the Eavquent trait, so you leave open the possibility of packages other than Eavquent using magic methods as well.
This is a breaking change, and models using Eavquent would need to be updated with the following method:
Please let me know your thoughts