search

IsraelOrtuno / pipedrive

Complete Pipedrive API client for PHP
MIT License
166 stars 58 forks source link

Add ItemSearches endpoint, deprecate SearchResults #100

Closed simensen closed 3 years ago

simensen commented 3 years ago

We'll want to add the property to Pipedrive.php as well, but we can't just yet as it would conflict with #99. But, to be fair, it might already conflict with that PR so oh well. :)

 * @property-read ItemSearches $itemSearches

If you want to do it yourself, awesome. If you want me to do it after you merge the other PRs, just let me know!

simensen commented 3 years ago

Yeah, looks like this is conflicting as expected. Happy to resolve this for you but don't want to double up on the work. :)

simensen commented 3 years ago

Also, had meant to include the docs link for this showing that SearchResults is indeed deprecated:

https://developers.pipedrive.com/docs/api/v1/#!/SearchResults

image

It apparently still works, so I left the code but I opted to use the @deprecated tag on the class instead so that people using it would get the hint.

IsraelOrtuno commented 3 years ago

Feel free to resolve the conflicts or I can do it myself by tomorrow :) thanks a lot!

simensen commented 3 years ago

Cool. Done. Got lazy and did it w/ the GitHub UI. Not sure how I feel about that. Heh.

simensen commented 3 years ago

Let me know if you want me to do more on this. :)

simensen commented 3 years ago

Thanks for the merge!