IsraelOrtuno / pipedrive

Complete Pipedrive API client for PHP
MIT License
166 stars 58 forks source link

laravel 4.2; guzzle 4 & 5 #11

Closed 3mg closed 8 years ago

3mg commented 8 years ago

Hi! I have implemented version that works with guzzle 4 & 5 and laravel 4.2. Also made api url parameter configurable. It works like before by default, just 2 new optional config parameters added:

'pipedrive' => [
    'token' => $_ENV['PIPEDRIVE_API_KEY'],
    'uri'   => $_ENV['PIPEDRIVE_API_URI'],
    'guzzle_version'   => 4,
]
IsraelOrtuno commented 8 years ago

Looks nice, will have a look these days :D thanks for contributing

IsraelOrtuno commented 8 years ago

Does PipedriveClient4 work fine with Guzzle 5 as well?

3mg commented 8 years ago

Yes, it works with both 4 and 5.

IsraelOrtuno commented 8 years ago

Will test all and merge. I think this will also let me tag a 1.0 with a few more changes :D

IsraelOrtuno commented 8 years ago

@3mg had no time to review this, still on queue, haven't forgotten ;D