IsraelOrtuno / pipedrive

Complete Pipedrive API client for PHP
MIT License
166 stars 58 forks source link

Delete participants endpoint not working #78

Closed leik-software closed 4 years ago

leik-software commented 4 years ago

The method \Devio\Pipedrive\Resources\Deals::deleteParticipant is not working, it produces an error "Participant ID not found". This code is not working:

public function deleteParticipant($id, $deal_participant_id) { return $this->request->delete(':id/participants', compact('id', 'deal_participant_id')); }

But with this fix it works like expected: public function deleteParticipant($id, $deal_participant_id) { return $this->request->delete(':id/participants/:deal_participant_id', compact('id', 'deal_participant_id')); }

IsraelOrtuno commented 4 years ago

Thanks! Could you just send this as PR?

On Tue, 3 Dec 2019 at 10:42, leik-software notifications@github.com wrote:

The method \Devio\Pipedrive\Resources\Deals::deleteParticipant is not working, it produces an error "Participant ID not found". This code is not working:

public function deleteParticipant($id, $deal_participant_id) { return $this->request->delete(':id/participants', compact('id', 'deal_participant_id')); }

But with this fix it works like expected: public function deleteParticipant($id, $deal_participant_id) { return $this->request->delete(':id/participants/:deal_participant_id', compact('id', 'deal_participant_id')); }

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/IsraelOrtuno/pipedrive/issues/78?email_source=notifications&email_token=AANP7SP7ZZIAPBSMP75J3J3QWYSY3A5CNFSM4JUU6FKKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H5TNQWA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANP7SNVLRHASZ7IZDYW63TQWYSY3ANCNFSM4JUU6FKA .

--

Un saludo Israel Ortuño

leik-software commented 4 years ago

I did. It's my first contribution, be patient.

Best Regards

Alex

Dipl.Medientechniker (FH)

Senior Backend Developer

Edmund-Wellenstein-Straße 26 40885 Ratingen

Tel: +49 173 3715 775

Am Di., 3. Dez. 2019 um 10:48 Uhr schrieb Israel Ortuño < notifications@github.com>:

Thanks! Could you just send this as PR?

On Tue, 3 Dec 2019 at 10:42, leik-software notifications@github.com wrote:

The method \Devio\Pipedrive\Resources\Deals::deleteParticipant is not working, it produces an error "Participant ID not found". This code is not working:

public function deleteParticipant($id, $deal_participant_id) { return $this->request->delete(':id/participants', compact('id', 'deal_participant_id')); }

But with this fix it works like expected: public function deleteParticipant($id, $deal_participant_id) { return $this->request->delete(':id/participants/:deal_participant_id', compact('id', 'deal_participant_id')); }

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/IsraelOrtuno/pipedrive/issues/78?email_source=notifications&email_token=AANP7SP7ZZIAPBSMP75J3J3QWYSY3A5CNFSM4JUU6FKKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H5TNQWA , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AANP7SNVLRHASZ7IZDYW63TQWYSY3ANCNFSM4JUU6FKA

.

--

Un saludo Israel Ortuño

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/IsraelOrtuno/pipedrive/issues/78?email_source=notifications&email_token=ANMWIZPP24TYP3LWV7H3S2TQWYTPLA5CNFSM4JUU6FKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFYYGWA#issuecomment-561087320, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANMWIZKPXQ65AIGXT5C2TLTQWYTPLANCNFSM4JUU6FKA .

IsraelOrtuno commented 4 years ago

Thanks for the PR 👍