search

IsraelOrtuno / pipedrive

Complete Pipedrive API client for PHP
MIT License
166 stars 58 forks source link

missing options #89

Closed danijelk closed 4 years ago

danijelk commented 4 years ago

Would it be a good idea to use $options here instead of $fields as with find() to open up possibility to use 'start, exact_match and limit' from the api? https://developers.pipedrive.com/docs/api/v1/#!/Organizations/get_organizations_search

https://github.com/IsraelOrtuno/pipedrive/blob/28c46ce870430de448b884e1740d70fb9f9aaf80/src/Resources/Traits/Searches.php#L15

IsraelOrtuno commented 4 years ago

Do you mean a third $options parameter? Since changing fields now would be breaking change

danijelk commented 4 years ago

yes adding $fields = [], $options = [] would work. Then nothing else would be needed inside the method.

IsraelOrtuno commented 4 years ago

There was also a bug since options was never declared and was passing that var to the request

danijelk commented 4 years ago

Correct, two fixes for one :) thanks for quick action.