search

IsraelOrtuno / pipedrive

Complete Pipedrive API client for PHP
MIT License
166 stars 58 forks source link

Changes on API endpoints in March 2021 #96

Closed LeMajstor closed 1 year ago

LeMajstor commented 3 years ago

Pipedrive developers team are going to change some endpoints, among them:

There's going to have some update to support these new changes?

IsraelOrtuno commented 3 years ago

Yeah sure, do you have more info about this update?

LeMajstor commented 3 years ago

Sure, here goes the link to their documentation explaining about the changes.

noudard commented 3 years ago

They provide a new endpoint itemSearch

MCKLtech commented 3 years ago

+1 on this issue. Are you accepting PRs? We may be able to help abit.

IsraelOrtuno commented 3 years ago

@MCKLtech I do accept, any help is appreciated

simensen commented 3 years ago

@IsraelOrtuno @MCKLtech The new endpoint for /itemSearch endpoint is supported by #100. Unclear if it supports everything, but I'm guessing it's all good to go? It doesn't address the new search endpoints for individual resources (deals, persons, etc), though.

IsraelOrtuno commented 3 years ago

It does not apply for deals, persons, organizations or products, those are still missing

IsraelOrtuno commented 3 years ago

Not sure if we could include them in this same class to prevent breaking changes in those classes

MCKLtech commented 3 years ago

As far as I'm aware itemSearch is the core functionality and everything else e.g. Deals, Persons is a wrapper of that.

The lazy part of me is wondering can we make the current (And soon to be deprecated) implementations compatible with itemSearch to avoid sudden breakages.

ampkeegan commented 3 years ago

Bringing this back up as it's eminent now. One thing I noticed is the FindByName trait says it is deprecated in your code, but the API documentation doesn't say it will be deprecated for the /Users endpoint.