Issafalcon / lsp-overloads.nvim

Extends the native nvim-lsp handlers to allow easier navigation through method overloads.
MIT License
97 stars 4 forks source link

Doesn't work with minimal config #47

Open leoshatrushin opened 3 months ago

leoshatrushin commented 3 months ago

Minimal config with nvim-cmp: https://github.com/leoshatrushin/tmp-minconfig Environment: nvim v0.10.0, kitty 0.34.1 with no config, macOS 14.3.1

Tests: touch js.js, :LspInstall tsserver, let x = "a"; x.match touch cpp.cpp, :LspInstall clangd, int main() { std::max } I use nvim-cmp to go down to the right function then attempt to press the next_signature keymap

Doesn't work with either default keymaps or custom keymaps - "next overload" makes no change in signature window, random stuff like going to a newline happens instead

leoshatrushin commented 3 months ago

Ok I think I see now that the signature help window once you type "(" after the function is different from the nvim-cmp preview. So there's no way to view overloads from inside the nvim-cmp preview window?

Issafalcon commented 2 months ago

Hi @leoshatrushin - Yes, this plugin hasn't got any integration built in with nvim-cmp (or any completion engine really). It's something that would be handy to have as a feature, but I am very limited on time as it stands for a while now.

By all means, raise that feature request. I'm hoping that someone else would see that and have a bit more time than myself to look into implementing it.

On the other hand, I'm not sure if there already exists a plugin that adds overload signatures into a cmp engine, so it might be worth looking into that initially.