search

Issafalcon / neotest-dotnet

Neotest adapter for dotnet
MIT License
73 stars 29 forks source link

Allow dap adapter name to be passed in as config value #85

Closed wambldor closed 9 months ago

wambldor commented 9 months ago

Hi,

I wanted to use the plugin for debugging UnitTests, but unfortunately the plugin seems to search for a debug adapter named netcoredbg. The debug adapter name should be coreclr, as described in the nvim-dap repository. When debugging my application, my configuration with the name coreclr works.

Thank you for the work on this plugin, we can use any plugin for .net support!

Issafalcon commented 9 months ago

Thanks @wambldor. I believe you are free to name your adapter (i.e. the dap.adapters.) configuration, anything you like, as long as your configurations reference the same name.

In reality, the name of the dap adapter being used should be a configuration value that can be passed in, given that it could literally be any value.

I'll use this issue to create a new option to pass this in, but for the time being, to get it to work, just change the name used in you own dap config to 'netcoredbg' instead of 'coreclr'.

wambldor commented 9 months ago

Sorry, I didn't realize that the names of the dap adapters are freely selectable. Probably because I use mason-nvim-dap. There the names for the automatic installation are fixed.

If I find time I would like to create a pull request to make the name configurable.

Issafalcon commented 9 months ago

No problem @wambldor . I had to double check it myself to confirm!

That would be a great help if you could raise a PR. I'm working on a large feature change at the moment, so that's keeping me busy! No problem if you don't find the time though. I will get round to this eventually.

Issafalcon commented 9 months ago

Closing this as PR addresses it.