Change sklearn to scikit-learn in setup.py

BurgerAndreas commented 5 months ago

The 'sklearn' PyPI package is deprecated, use 'scikit-learn'
      rather than 'sklearn' for pip commands.

      Here is how to fix this error in the main use cases:
      - use 'pip install scikit-learn' rather than 'pip install sklearn'
      - replace 'sklearn' by 'scikit-learn' in your pip requirements files
        (requirements.txt, setup.py, setup.cfg, Pipfile, etc ...)
      - if the 'sklearn' package is used by one of your dependencies,
        it would be great if you take some time to track which package uses
        'sklearn' instead of 'scikit-learn' and report it to their issue tracker
      - as a last resort, set the environment variable
        SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True to avoid this error

      More information is available at
      https://github.com/scikit-learn/sklearn-pypi-package

BurgerAndreas commented 5 months ago

Also setup.py seems to have a missing ,: https://github.com/IssamLaradji/sps/blob/6d112a1da97a4a2195c01cd51e96e3f0fbdd0c5b/setup.py#L13

IssamLaradji commented 5 months ago

Thanks @BurgerAndreas if you would like to make a pull request with these changes, I can approve it and have you as a contributer.

IssamLaradji / sps

Change sklearn to scikit-learn in setup.py #6