search

Issung / GChan

Scrape boards & threads from 4chan. Download images, videos and HTML if desired.
GNU General Public License v3.0
60 stars 9 forks source link

Fix GenerateNewFilename function to be much sorter and easy to read. #26

Closed orkhanag closed 1 year ago

orkhanag commented 1 year ago

I think this is what you meant. If you believe anything is wrong I can fix it further.

Issung commented 1 year ago

This is looking much better now thanks to your help! Do you have any screenshots of tests you have done to show the different formats are working as intended?

Issung commented 1 year ago

I need you to make one small change to this PR before we merge it, I will test it myself when that is ready. I have another issue created and someone agreed to work on it. I will get back to you when that is done and this can be updated.

orkhanag commented 1 year ago

Sorry for the late response. I couldn't find how to test the application, it will be great if you test it by yourself. Do you have a particular change in your mind? Or should I make any random changes to PR?

Issung commented 1 year ago

No worries! Just leave the PR as is untouched for now, I have someone else making a change soon, when they are done I will get you to update your fork with their changes, then make a small change. I'll notify you when that is :)