IstoraMandiri / spectrum

💠 Full Gamut Ethereum Lightsuite
BSD 3-Clause "New" or "Revised" License
58 stars 14 forks source link

Keystore options - Seed Recovery, Paper Wallet #46

Open MDSchaeffer opened 7 years ago

MDSchaeffer commented 7 years ago

1) Recover from Seed phrase option I would find value in being able to import an account from the seed phrase. I believe this is the most common way of offline storage of an account and would be a great way to on-ramp new users with an existing keystore.

2) Paper Wallet print out for off-line storage This could be a check-box option during Create Keystore modal. Upon confirmation of all required fields and Go, the print keystore/QR code popup could appear.
Later in normal usage, this could be printed from the Edit Keystore: Single Account modal, as a button aside of the Download JSON button.

IstoraMandiri commented 7 years ago

Item 1 is a duplicate of #20

The idea of adding the a keystore / qr code outputs for paper wallet is certainly useful but should be considered a potential security issue (if it's ever shown in plain text, it could be captured remote desktop software or over-the-shoulder cctv, for example).

It makes sense for both HD wallets to show a QR code for the encrypted keystore, but for the raw PK or mnemonic, I think it should be restricted to offline mode (and/or show some extreme warning message).

💸 x 10 for this