search

IstoraMandiri / spectrum

💠 Full Gamut Ethereum Lightsuite
BSD 3-Clause "New" or "Revised" License
58 stars 14 forks source link

Turn on webpack source maps by default #57

Closed cloudonshore closed 7 years ago

cloudonshore commented 7 years ago

Since many of the features requested & bugs reported are sparsely documented, having rich debugging & console errors that link to the source files would lower the barrier of entry to new developers contributing.

IstoraMandiri commented 7 years ago

Good idea. Thanks @cloudonshore .

💸 +5

What's your address?

cloudonshore commented 7 years ago

@hitchcott I'm still setting up my wallet, I'll have my address soon. Ah instead of adding source maps in webpack.production.config.js I more meant that they should be added in webpack.development.config.js so that the developer can better debug during development. I had my fork own for where I had done this. Should I make a PR?

cloudonshore commented 7 years ago

@hitchcott 0xda66615cB1519599AE15EF5597D2aEcaCce75e64

IstoraMandiri commented 7 years ago

@cloudonshore the source map is already added to development, see https://github.com/spectrum/spectrum/blob/develop/webpack.development.config.js#L7

cloudonshore commented 7 years ago

@hitchcott ah yeah, it's post-babel code though. Not very readable and hard to debug. I would def suggest cheap-module-eval-source-map if you're trying to keep a quick compile time but have something more readable that's easier to debug.

IstoraMandiri commented 7 years ago

@cloudonshore thanks for the suggestion, i'll upgrade to that

💸 5 + 5 = +10

IstoraMandiri commented 7 years ago

@cloudonshore

https://etherscan.io/tx/0x40201e53002f11150b3b00bd5b676cd127945cfc246dd037de4ec05e162afe9a