search

Isysxp / Pico_1140

A PDP11/40 emulator that will run Unix v5/6
GNU General Public License v3.0
77 stars 8 forks source link

KED does add random chars with RT-11 v5.07SB on Pico 1140 #5

Closed guidol70 closed 1 year ago

guidol70 commented 1 year ago

When using Pico 1140 with RT-11 v5.04F and his KED file can be edited/saved and would been saved correctly. When using Pico 1140 with RT-11 v5.07SB ans his KED then random chars with random counts of chars are appened to the file - so the file isnt useable anymore :( Sometimes these random chars look like a part of the RT-"source"-code - maybe it may called something like a "memory-leak"?

I also copied a fresh KED from the v5.07-Install image, but it was the same with 85 blocks & problems :(

Using the same RT-11 v5.07SB image with simh this problem doenst occur.

rt11v507sb.zip

Isysxp commented 1 year ago

Dear Guido,

Some interesting problem. Firstly, I have throttled the keyboard poll rate. Part of the Editor problem is due to multicharacter responses from the terminal. This can overflow the RT11 keyboard handler. The terminal output speed is unchanged. Secondly, I have allowed for partial sector writes in the RK11 device. Some RT11 apps assume that a partial sector write of less that 256 words will fill the rest of the sector with zeros. I hope this has fixed your problem. Do let me know.

Regards, Ian.

From: Guido Lehwalder @.> Sent: 05 December 2022 12:46 PM To: Isysxp/Pico_1140 @.> Cc: Subscribed @.***> Subject: [Isysxp/Pico_1140] KED does add random chars with RT-11 v5.07SB on Pico 1140 (Issue #5)

⚠ External sender. Take care when opening links or attachments. Do not provide your login details.

When using Pico 1140 with RT-11 v5.04F and his KED file can be edited/saved and would been saved correctly. When using Pico 1140 with RT-11 v5.07SB ans his KED then random chars with random counts of chars are appened to the file - so the file isnt useable anymore :(

This also occurs on new files e.g TEST.TXT (which then can be deleted and doenst harm, like a bad edited STRTSB.COM) This seem also to occur with FatFS ff14a and ff15

Using the same RT-11 v5.07SB image with simh this problem doenst occur.

rt11v507sb.ziphttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FIsysxp%2FPico_1140%2Ffiles%2F10154218%2Frt11v507sb.zip&data=05%7C01%7Cian.schofield%40newcastle.ac.uk%7C3cb90bbd7a48484ac79008dad6beb3e3%7C9c5012c9b61644c2a91766814fbe3e87%7C1%7C0%7C638058412505568560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=x6x6j90IZEzrG4t3Tfqn9gA2kmfQHs6SSBNaxr7%2BAao%3D&reserved=0

— Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FIsysxp%2FPico_1140%2Fissues%2F5&data=05%7C01%7Cian.schofield%40newcastle.ac.uk%7C3cb90bbd7a48484ac79008dad6beb3e3%7C9c5012c9b61644c2a91766814fbe3e87%7C1%7C0%7C638058412505568560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=wzlW9y9XoSqkEfIg2pPvWFJdwdlb1JQ80ZO8ceX6crg%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACYZOB7TLASXIC2H2PRPNFLWLXPZRANCNFSM6AAAAAASUHMQVI&data=05%7C01%7Cian.schofield%40newcastle.ac.uk%7C3cb90bbd7a48484ac79008dad6beb3e3%7C9c5012c9b61644c2a91766814fbe3e87%7C1%7C0%7C638058412505568560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=kEWqeCLJ0PdfQF2S1z7IRFFTKnimf3NB4W5PxMSEigQ%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.***>

guidol70 commented 1 year ago

Dear Guido, Some interesting problem. Firstly, I have throttled the keyboard poll rate. Part of the Editor problem is due to multicharacter responses from the terminal. This can overflow the RT11 keyboard handler. The terminal output speed is unchanged. Secondly, I have allowed for partial sector writes in the RK11 device. Some RT11 apps assume that a partial sector write of less that 256 words will fill the rest of the sector with zeros. I hope this has fixed your problem. Do let me know.

Dear Ian, many Thanks for this fast bugfix ;) I tested the corresponding KEDs in their RT-11 versions and had successful results now in v5.04F and v5.07SB.

But now I have another interesting find in RT-11 v4.00C - dont know if this was this way before the bugfix:

.DIR STARTF.COM

STARTF.COM     1P
 1 Files, 1 Blocks
 1592 Free blocks

.RUN KED STARTF.COM
 ?KED-F-Unable to open output file

.RUN KED TEST.TXT
 ?KED-F-Unable to open input file

KED on RT-11 v4.00c cant find/edit a PROTECTED file nor can create a new (TEST.TXT) file. When I unprotect the file with RENAME /NOPROTECTION STARTF.COM STARTF.COM the file can be edited with KED from RT-11 v4.00C

Isysxp commented 1 year ago

Dear Guido,

Thanks. Under RT11 you cannot edit a protected file .... I do not think this is anything to do with the patch. Also, you cannot edit a non-existent file. Rather than me go into the details, I suggest you read the relevant sections in the RT11 users guide.

Regards, Ian.

From: Guido Lehwalder @.> Sent: 06 December 2022 10:57 AM To: Isysxp/Pico_1140 @.> Cc: Ian Schofield @.>; Comment @.> Subject: Re: [Isysxp/Pico_1140] KED does add random chars with RT-11 v5.07SB on Pico 1140 (Issue #5)

⚠ External sender. Take care when opening links or attachments. Do not provide your login details.

Dear Guido, Some interesting problem. Firstly, I have throttled the keyboard poll rate. Part of the Editor problem is due to multicharacter responses from the terminal. This can overflow the RT11 keyboard handler. The terminal output speed is unchanged. Secondly, I have allowed for partial sector writes in the RK11 device. Some RT11 apps assume that a partial sector write of less that 256 words will fill the rest of the sector with zeros. I hope this has fixed your problem. Do let me know.

Dear Ian, many Thanks for this fast bugfix ;) I tested the corresponding KEDs in their RT-11 versions and had successful results now in v5.04F and v5.07SB.

But now I have another interesting find in RT-11 v4.00C - dont know if this was this way before the bugfix:

.DIR STARTF.COM

STARTF.COM 1P 1 Files, 1 Blocks 1592 Free blocks

.RUN KED STARTF.COM ?KED-F-Unable to open output file

.RUN KED TEST.TXT ?KED-F-Unable to open input file

KED on RT-11 v4.00c cant find/edit a PROTECTED file nor can create a new (TEST.TXT) file. When I unprotect the file RENAME /NOPROTECTION STARTF.COM STARTF.COM the it can be edited with KED from RT-11 v4.00C

— Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FIsysxp%2FPico_1140%2Fissues%2F5%23issuecomment-1339142827&data=05%7C01%7Cian.schofield%40newcastle.ac.uk%7Cd4072d9e34de42218ca508dad778ac75%7C9c5012c9b61644c2a91766814fbe3e87%7C1%7C0%7C638059210530212304%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=WLThbWyRVZQ2mlgHjZ9fl2pMFuqwBkKcVwubW1kiKa8%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACYZOB2SQHDTVNSLI5V2JXDWL4LZVANCNFSM6AAAAAASUHMQVI&data=05%7C01%7Cian.schofield%40newcastle.ac.uk%7Cd4072d9e34de42218ca508dad778ac75%7C9c5012c9b61644c2a91766814fbe3e87%7C1%7C0%7C638059210530212304%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=EeT5sbWwXFSaryzoWQoYitR7%2FInxDsqOJUVSysuL70E%3D&reserved=0. You are receiving this because you commented.Message ID: @.***>

guidol70 commented 1 year ago

Dear Guido, Thanks. Under RT11 you cannot edit a protected file .... Also, you cannot edit a non-existent file. Rather than me go into the details, I suggest you read the relevant sections in the RT11 users guide.

Dear Ian, I think Iam somewhat spoiled from RT-11 V5.xx ;) where KED is asking if you want to create a new file or on a protected file if you want to inspect it. Also it got PROTECT/UNPROTECT against the longer RENAME command in v4.xx I did read already some PDFs (partly) but I had - I think - copied a file and edit this in v4.xx A new file in v4.xx SET EDIT KED EDIT /CREATE TEST.TXT

So your Bugfix is completly right :)

Kind Regards Guido