search

Itai-Nelken / aptpac

A simple wrapper for 'pacman' with a syntax similar to 'apt' to help people transitioning to Arch and Arch based distributions like Manjaro.
https://itai-nelken.github.io/aptpac/
MIT License
27 stars 5 forks source link

Update README.md #9

Closed CleanMachine1 closed 3 years ago

CleanMachine1 commented 3 years ago

Also don't you mean x86 rather than x64..

Itai-Nelken commented 3 years ago

I do mean x64 (or amd64), x86 is i386 (i686). github actions only support 64bit x86 (unless you use qemu and docker stuff). if you think that x86_64 or x86 (64 bit) sounds better you can change it.

CleanMachine1 commented 3 years ago

amd64 wiki, type that here

duck.com or your spying google and you will find that amd64 refers to X86-64

CleanMachine1 commented 3 years ago

I will update it in a few hours

Itai-Nelken commented 3 years ago

I edited the builds and checks, now they are in the same workflow, and I got arm64 working on github actions! there is a problem with cmake on armhf docker containers running with qemu... so my self hosted runner will be for armhf for now...

CleanMachine1 commented 3 years ago

How is it self hosted, how is your pi communicating with git and github?

Itai-Nelken commented 3 years ago

How is it self hosted, how is your pi communicating with git and github?

github support armhf runners, so you just have to create one in the settings of the repository and they provide you with the commands to install the software.

CleanMachine1 commented 3 years ago

How is it self hosted, how is your pi communicating with git and github?

github support armhf runners, so you just have to create one in the settings of the repository and they provide you with the commands to install the software.

very interesting, have you got a link or anything to read up on

Also not that it matters, but does it use the github action minutes?

Itai-Nelken commented 3 years ago

https://docs.github.com/en/actions/hosting-your-own-runners/adding-self-hosted-runners I know it isn't very secure to use on public repositories... thats why I only start it when I need it to run the build checks.

Itai-Nelken commented 3 years ago

I don't think it uses actions minutes (I hope)

CleanMachine1 commented 3 years ago

About it being unsafe, surely you should edit the workflow files to remove it running at PR, and just have it as commits maybe, or something where only running the action when code is approved

CleanMachine1 commented 3 years ago

Don't know what happened with that commit, it seem to bug out the logos because of a line I had put when linting

Itai-Nelken commented 3 years ago

I want it to run on pr's, but anyway I only run it when I need it and after I review the code and make sure its not malicious. if you look at how much time the first armhf checks for this pr took, you will see its ~8 hours, that is because it had to wait until I ran the script.

Itai-Nelken commented 3 years ago

Don't know what happened with that commit, it seem to bug out the logos because of a line I had put when linting

I fixed them.

Itai-Nelken commented 3 years ago

can I merge?

Itai-Nelken commented 3 years ago

thanks a lot!