ItayXD
commented
8 years ago Thanks for noting! Would you mind creating a pull request with your fix? I know it is very minor but I barely have time to work on it these days. I'll be glad if I could just login and approve the request. Also if you see anything else that needs to be fixed / changed please let me know. Itay
On Jul 20, 2016 8:32 PM, "dreg" notifications@github.com wrote:
Thank you for the fantastic plugin, saved me a ton of time. Super minor but clicking on the tooltip pop-up didn't close it as expected. I changed line 75:
tooltip.bind( 'click', remove_tooltip);
to:
tooltip.bind( 'click', function(){ remove_tooltip(); });
and it's working as expected now. Worth a patch in the future or a migration from .bind() to .on()?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ItayXD/responsive-tooltip/issues/5, or mute the thread https://github.com/notifications/unsubscribe-auth/ABzFDqiInAhV0t7a9SEnND3UMonuvwsvks5qXluagaJpZM4JRBPe .
dreg
Thank you for the fantastic plugin, saved me a ton of time. Super minor but clicking on the tooltip pop-up didn't close it as expected. I changed line 75:
tooltip.bind( 'click', remove_tooltip);
to:
tooltip.bind( 'click', function(){ remove_tooltip(); });
and it's working as expected now. Worth a patch in the future or a migration from .bind() to .on()?