search

Iterable / iterable-web-sdk

Iterable SDK for interacting with the Iterable API to implement inside JavaScript and Node projects
https://iterable.com
MIT License
9 stars 9 forks source link

Rework Embedded Session Manager #362

Closed hardikmashru closed 5 months ago

hardikmashru commented 5 months ago

JIRA Ticket(s) if any

Description

Test Steps

mprew97 commented 5 months ago

@bradumbaugh for your vis

mprew97 commented 5 months ago

One thought I have here, specifically after working in the embeddedSessionManager some more, could we just add a field on to the EmbeddedSession class impressions where we track and store impressions? An impression has to exist as part of a session so it makes sense to make it a part of that class and not have two separate objects to keep track of.

hardikmashru commented 5 months ago

Hi @mprew97 yes that is what I thought so but I guess we had followed the same code as Android when we worked on web implementation. Let me know if you need me to work on your suggestion before you merge this.