Iterable / react-native-sdk

MIT License
37 stars 33 forks source link

Move dependencies to peer dependencies #603

Closed johnhaup closed 6 days ago

johnhaup commented 2 weeks ago

✏️ Description

Using the UI components (example: Inbox) breaks because react navigation and safe area context are dependencies in the SDK, so they get installed in the package's own node_modules (node_modules/@iterable/react-native-sdk/node_modules). The makes the components look for navigation context and safe area context from an instance in its own node_modules, instead of the consumer's project.

lposen commented 2 weeks ago

Approved. Looks good to me.

johnhaup commented 1 week ago

This also address #596