search

Iterable / swift-sdk

Iterable's iOS SDK. Receive and track pushes to Iterable from your iOS app.
https://iterable.com/
MIT License
86 stars 68 forks source link

Mapping PrivacyInfo in podspec file #760

Open silvgabriel opened 2 months ago

silvgabriel commented 2 months ago

Mapping PrivacyInfo in podspec file

🔹 Jira Ticket(s)

✏️ Description

Please provide a brief description of what this pull request does.

silvgabriel commented 2 months ago

You forgot to map the PrivacyInfo file type in the podspec

Ayyanchira commented 2 months ago

Thanks for the PR!

I had tested an App with SPM generated Privacy report which had data from SDK's manifest.

@silvgabriel, does the Cocoapods based project not pull privacy manifest from SDK when generating report? If so, does this change rectify the issue?

silvgabriel commented 2 months ago

Hi @Ayyanchira

SPM is working well because you only map the Resources folder and everything we have inside this folder will appear in the project. In the CocoaPod podspec you map the file types in the resource part and the xcprivacy type is missing, so the private manifest file does not appear/mapped. Cocoapods will just pull the files into the generated report that is mapped into the podspec.

This PR fixes the CocoaPod part, check the image below, it is the Iterable-iOS-SDK pod installed in my project: image

Another way to resolve this is to equalize the podspec with the SPM file by mapping just the Resource folder (without specifying types) so the CocoaPods will map all files inside the resource folder.