Closed damienen closed 5 months ago
Few observations and clarifications
Failure was encountered below; Data NFT was first penalized 10% then slashed. Relevant failure message required. https://devnet-explorer.multiversx.com/transactions/986a7a6c448025061d3c823b9324699b14812fa26ac84b0b4f650875b07f6ec7
If a claim date is set for owners, this is only effective in the admin as a parameter. There is no current followup claim action implemented.
If a creator has been penalized, the values are stored in the dashboard, is not consumable by the creator.
Claims for creators are yet to be implemented. To test once penalization has been enforced.
So, regarding point no. 5, that is the expected behaviour. Once a user withdraw the bound it will disappear from the bonding contract mapping, but you still can trade it on data dex but without a liveliness score.
I think after @bucurdavid's upgrade today it won't disappear from the map anymore
Not really, it's removed from the main mapper, which is used to get all active bonds
To keep everyone on the same page, a few consolidated feedback below.
Attempted to add 10 ITHEUM slashable bond to 3600 seconds entry.
Entries were 3600 seconds with 12 ITHEUM 2 seconds with 14 ITHEUM 1000 seconds with 250 ITHEUM
Cosmetic:
When mentioning to the user that they can withdraw with no penalty. there can be cases they were penalized for other behavior.
Therefore suggest mentioning there will be no Early withdrawal Penalty instead of just Penalty.
"You can withdraw your full bond with no penalty"
Upon deleting all period bonding periods and amounts blank page is seen.
Attempted to remove all periods to update the already existing entry for 3600 seconds with 12 ITHEUM and update it to 10 ITHEUM
https://deploy-preview-1252--frosty-hermann-85ca4f.netlify.app/bonding
Should be solved @fuzzyduke
Item 1
Bonding dashboard is not populating data NFTs. Data NFT minted: https://devnet-explorer.multiversx.com/transactions/6ac9a04bc55daf0c21f22e7690be63f5434916225f7f6d8196ac52966954b1f1
Item 2
Item 3
Item 4
Was able to apply 5% for penalty on a Data NFT despite the minimum penalty being set to 6%
After applying 5% penalty to the data NFT, 6% was deducted.
Item 3
- mint Data NFT
- apply 9% penalty
- click withdraw (current early withdraw percent is set to 50%)
- Upon withdrawing it is seen that 5 ITHEUM is sent back. Only the early withdrawal fees was deducted, not the penalty of .9 https://devnet-explorer.multiversx.com/transactions/b3481e9fde9851df6c02e49377f202ad6f28d400abd2d2a3db4f4cc5dd0e6e35#71ab950d69625d25695d54267d4017ba6d85c215b3aa601f6d1ef77d6c382b64
Indeed, I can confirm this is the logic of the SC and that this bug is coming from the fact that withdraw is using bond_amount instead of remaining_amount for the withdraw operation: https://github.com/Itheum/core-mx-life-bonding-sc/blob/bb99e6ed0e348177bde61c184d408338258c053c/src/lib.rs#L137
Will attach wireframe privately