newbreedofgeek commented 1 year ago

[x] In the trade data form, manually select the royalty box and clear it. NaN appears. Ideal scenario is that user can manually enter a number without NaN appearing.. if this is too hard, then the user cannot clear this field manually and only can click on the top/down arrows to select values.

Same thing happens with Number of Copies:

newbreedofgeek commented 1 year ago

[x] When the Trade Data Form opens, along with checking for values from smart contract for min/max supply/royalty and tax.. also check is the contract is PAUSED. And if so - show a message to user in the same current header error component : "Data NFT Minting is currently paused"

Also disable the "Mint & Trade as NFT" button

newbreedofgeek commented 1 year ago

[x] When the Trade Data Form opens, along with checking for values from smart contract for min/max supply/royalty and tax.. also check is the contract if current user is WHITELISTED. And if NOT - show a message to user in the same current header error component with the message : "You are not currently whitelisted to mint Data NFTs".

Also disable the "Mint & Trade as NFT" button

fuzzyduke commented 1 year ago

Max Copies is set to 20. Is this the intended max limit? If so, probably the message should not be placed as a suggestion but rather as a statement of max quantity.

fuzzyduke commented 1 year ago

UI Suggestion: Clear visual segregation suggested between short title, title and description.

fuzzyduke commented 1 year ago

Cosmetic:

"Read Terms of Use" and "Read about Anti-Spam Fee" popups need to be updated with content.

fuzzyduke commented 1 year ago

Wallet: Maiar defi wallet

Description: Cancelling a transaction from wallet during Data NFT minting process takes user back to the popup however exiting the popup should be more user friendly. Currently the user has to click close on the error message to close the popup "Data Advertising Progress"

This action also closes the main popup "Trade a Data Stream as a Data NFT-FT" and clears the data entered.

Steps

Add in details to mint the Data NFT - https://deploy-preview-124--frosty-hermann-85ca4f.netlify.app/selldata
Click "Mint and Trade as NFT"
Cancel wallet transaction when prompted.

Expected Result

Once the Transaction is cancelled it should be easier to get to the "Trade a Data Stream as a Data NFT-FT" page.
The data entered should be retained on page "Trade a Data Stream as a Data NFT-FT" even if the transaction is cancelled.

Actual Result

Once the transaction is cancelled an error message is seen. Upon closing this message the navigation is seen to https://deploy-preview-124--frosty-hermann-85ca4f.netlify.app/selldata

Images Page - Trade a Data Stream as a Data NFT-FT

Page - Data Advertising Progress

fuzzyduke commented 1 year ago

Cosmetic:

Popup probably needs a timeout until it closes. Currently stays until specifically closed.

newbreedofgeek commented 1 year ago

Wallet: Maiar defi wallet

Description: Cancelling a transaction from wallet during Data NFT minting process takes user back to the popup however exiting the popup should be more user friendly. Currently the user has to click close on the error message to close the popup "Data Advertising Progress"

This action also closes the main popup "Trade a Data Stream as a Data NFT-FT" and clears the data entered.

Steps

Add in details to mint the Data NFT - https://deploy-preview-124--frosty-hermann-85ca4f.netlify.app/selldata

Click "Mint and Trade as NFT"

Cancel wallet transaction when prompted.

Expected Result

Once the Transaction is cancelled it should be easier to get to the "Trade a Data Stream as a Data NFT-FT" page.

The data entered should be retained on page "Trade a Data Stream as a Data NFT-FT" even if the transaction is cancelled.

Actual Result

Once the transaction is cancelled an error message is seen. Upon closing this message the navigation is seen to https://deploy-preview-124--frosty-hermann-85ca4f.netlify.app/selldata

Images Page - Trade a Data Stream as a Data NFT-FT

Page - Data Advertising Progress

[ ] Update the UI so that when user closes the "process error" box, then the screen should not "hard reset" but the progress popup closes and the form is still on screen with user filled out data

newbreedofgeek commented 1 year ago

[x] Web Wallet: After user mints it redirects to web wallet and comes back with "Data NFT Minting" toast showing but the progress model closed. It's fine if the progress model closes, but once the "Data NFT Minting" is a success, we need to show a Chakra Popup with the same message as we do for other wallet progress updates, e.g.:

newbreedofgeek commented 1 year ago

[x] If the user mints an NFT and then immediately tries to mint again, they get the below error. A better UX would be to show a UI timer or message with "You need to wait XX until you can mint again". This timeout can be fetched from the Smart Contract.

newbreedofgeek commented 1 year ago

[x] "Frozen" UI design has not been implemented, based on new smart contract deployed today - we can query the contract for user data and get list of frozen SFTs. So this UI can not be built

@icegriffinguru u need to implement this frozen view for the Data NFT wallet as well.

newbreedofgeek commented 1 year ago

[x] When Min Royalties are more than 0, it should update the input box correctly. Here we have Min Royalties 10% but text box is showing 0

newbreedofgeek commented 1 year ago

[x] Error handling if NFT.strong fails. Currently if the IPFS save step fails, it just gets stuck in below screen. We need some error handling to tell user there was an issue.

We need to show this error box with the message, "IPFS storage has failed; no gas was deducted. Please try again".

icegriffinguru commented 1 year ago

Max Copies is set to 20. Is this the intended max limit? If so, probably the message should not be placed as a suggestion but rather as a statement of max quantity.

it's maxSupply value (Suggested: less than {maxSupply}</Text>)

BogdanCostinas commented 1 year ago

Visual Issue/Bug/Feedback

Wallet: Maiar App Browser: Google Chrome Device: Laptop

Description: Minting a Data NFT and owning one is really good, but what happen when I want to burn some of this supply? I can see how many Data NFTs are in the "collection" how many are out there, and I can Burn. The burn function worked properly ; but when checking after a refresh my supply is 4 out of 5.

Suggestion: After burning- Update the maximum number of NFTs from that collection If not possible- A "warning" message that x NFTs were burned

Steps

1) Go to : https://deploy-preview-124--frosty-hermann-85ca4f.netlify.app/ 2) Mint a Data NFT with more than 1 as the total supply 3) Go and see your Data NFT 4) Burn some of this supply ( min 1 ) 5 ) Check the description of the Data NFT

Expected Result

After burning I expected that the total supply to decrease with the amount of burned NFTs ( Visual )

Actual Result

The Maximum supply remained as minted

UPDATE!

After I've been disconnected, the UI now shows 4 instead of 5, but I've burned another 3, and the new Total supply is not updated (I tried to disconnect and re-connect multiple times )

UPDATE 2

Now the balance shows ok after one more refresh; But still it takes too long to be correctly displayed.

BogdanCostinas commented 1 year ago

Small Suggestion 1.Currently, there is a " You must agree on terms of use " Maybe we can change that text to " You must READ and Agree on Terms of Use

The same checkbox to be added in the "Anti Spam Fee"?

BogdanCostinas commented 1 year ago

Wallet: Maiar App Browser: Google Chrome Device: Laptop

Description: During the minting process your wallet is disconnected, and somehow the UI keeps you logged in. The pop up message presented in the picture attached it's still there and it's annoying that you need to refresh the page in order to make it disappear. Maybe adding a "close" button on that pop-up message?

Steps

1) Go to Itheum Data DEX 2) "Play around" or wait long enough until your wallet it's disconnected from the Data DEX 3) Go and Advertise your Data 4) Add the cloud storage links, title, description, how many NFTs and the royalties; Accept the terms of use 5) Click on Mint 6) Once the pop-up gives you the notification that you have a transaction to sign in to your wallet, this screen is "stuck" with this action and you need to refresh

Expected Behaviour Once my wallet has been disconnected from Itheum Data DEX I expect to be logged out or if I am in the minting process to have a way to close that and click on disconnect myself

Actual Behavior:

I am still logged in with no possibility of closing that pop-up message

BogdanCostinas commented 1 year ago

UI Suggestion:

Description: Data NFT Wallet shows the NFTs in a quite big format. Suggestion: Shrink the Data NFT Image Keep in the "preview" only what's in a green area and add an "EXPAND" button to show all the details of the NFT, such as " Owner, copies, description, creator etc "

newbreedofgeek commented 1 year ago

[x] Select these input boxes and hit the down and up keyboard arrow and the values go past the min and max values. These boxes should NOT go past the min/max values

newbreedofgeek commented 1 year ago

[x] Here the input box needs to start at 10 (as minRoyalty is 10) and the Min and Max values on the input box SHOULD NOT go over or under this if user interacts with it (via the arrows or up/down keys). Do the same with the Supply box as well

@icegriffinguru

fuzzyduke commented 1 year ago

suggestion :

Feature : Tagging

There should be tags associated to Data NFT for the purpose of filtering, this can be iterated upon. a. primary tags/filter; File Type[json, doc, xls, image, video], Industry[health, retail, gaming] b. additional tags; tutorial, analytics, rawdata, survey, research

fuzzyduke commented 1 year ago

Suggestion :

Feature : Request for dataset with bounty

This is a suggestion that requires refinement.

This feature enables a consumer/buyer to provide a schema of a desired dataset. The purpose of this feature is to enable the consumer to request for data/research they are in search of, and are willing to buy.

fuzzyduke commented 1 year ago

Description Intended to place in the value '999', However while clicking within box to "Backspace" the value 1, the action is not permitted.

Expected Behaviour Backspace should be permitted on single digit so the user can input any digit.

Actual Behaviour Backspace is not permitted when single digit is within cell.

fuzzyduke commented 1 year ago

Description: Attempted to place in the value "44" after selecting the input value "10" to be replaced. The action was not permitted. This could be because this validation is performed while the user is entering the value instead of performing this validation after leaving the text box.

Expected Behaviour: A user should be able to select "10" and type in "44" without the validation stopping them from doing so. As this is within acceptable bounds.

fuzzyduke commented 1 year ago

Cosmetic suggestion :

Description:

Post minting the data NFT the below popup is seen. Is it practical/feesible to place a link of the Data NFT Wallet within the popup? This be a hyperlink on the term within the popup "Data NFT Wallet" to make it easier for the user to navigate to the Data NFT.

fuzzyduke commented 1 year ago

The description of the Data NFT gets truncated. Will we have a detail page for the Data NFT? So all fields can be clearly seen.

BogdanCostinas commented 1 year ago

Incremental limitaion:

The predefined increment for the royalties is set to "5" This could be redefined to 1% when hitting "up or down "

BogdanCostinas commented 1 year ago

We have Claims History

Can we add Data NFT's history? Minting/Burning/Buying/Selling

BogdanCostinas commented 1 year ago

Community: Procure your own NFT on the marketplace The seller of the NFT= Creator of the NFT, the button "Procure" it's available, but the error pop up after you sign the transaction, trying to buy your own NFT

To reproduce : 1) Mint a Data NFT 2) List Your Data NFT 3) Try to procure your own NFT 4---- The results are in the pics attached

Expected Behavior: 1) Either disable the button "Procure" if the seller=creator 2) A warning message that it's your own NFT

BogdanCostinas commented 1 year ago

Community: There is a minor display bug on the Data NFT Marketplace It's displayed x out of "0"

BogdanCostinas commented 1 year ago

Internal Description:

Pop-up transaction messages have a strange behavior

Browser: Google Chrome Wallet: Defi Wallet

Steps to reproduce 1) Sign a transaction 2) Sign the second transaction 3) Get the error

Expected behavior: 1)Sign the second transaction and the pop up message to be displayed on top of the first message, not on the front of the first message 2)The TX messages to disappear automatically after some time

BogdanCostinas commented 1 year ago

Internal: Description: "I have read all the terms and agreed with them" box remains checked if you try to procure 1 Data NFT. It's sufficient to click on Procure and check the box and then you can either continue to buy the Data NFT or Cancel, if you try to procure another data NFT the checkbox remains checked in the same webpage session. It resets when you go to another tab ( eg. Home )

Steps: 1) Go to data nft marketplace 2) Try to Procure 1 data nft 3) Click " I have read all the terms and agreed with them" 4) 2 Options ( Procure or Cancel ) have the same output 5) Try to PROCURE another data nft and you already signed that you read the terms and agree with them

Expected behavior: If I either buy the NFT or close the buying tab, when I open again, or another data NFT, the "I have read all the terms...." it is not "checked" by default

Maiar Chrome Extension Google Chrome Laptop

BogdanCostinas commented 1 year ago

Community+Internal:

Suggestion: In the Data NFT Marketplace can we add a button to change the selling price? Or either delist a small part of the Data NFTs?

icegriffinguru commented 1 year ago

Internal: Description: "I have read all the terms and agreed with them" box remains checked if you try to procure 1 Data NFT. It's sufficient to click on Procure and check the box and then you can either continue to buy the Data NFT or Cancel, if you try to procure another data NFT the checkbox remains checked in the same webpage session. It resets when you go to another tab ( eg. Home )

Steps:

Go to data nft marketplace

Try to Procure 1 data nft

Click " I have read all the terms and agreed with them"

2 Options ( Procure or Cancel ) have the same output

Try to PROCURE another data nft and you already signed that you read the terms and agree with them

Expected behavior: If I either buy the NFT or close the buying tab, when I open again, or another data NFT, the "I have read all the terms...." it is not "checked" by default

Maiar Chrome Extension Google Chrome Laptop

Fixed. Will be reflected at next pull request.

BogdanCostinas commented 1 year ago

Description : Choosing the exact number as Royalty has a small issue, the 5% increment while typing was solved, and now we can choose 12 17 28 29, etc but there is an issue if I want to manually type 13 I cannot do that, except when I am selecting the second digit. If I am choosing both digits, it returns me the error that cannot be greater than 50

Steps to reproduce: Step 1 Go to Advertise Data Step 2 Go Royalties Step 3 Play with the numbers using keyboard and the issue will be visible

Expected behavior: If I want to write 16 or 50 or any value between 10 and 50, the system won't block me with this error message that the royalties cannot be greater than 50

BogdanCostinas commented 1 year ago

Issue Update

"VIEW DATA" using Maiar App ( xPortal ) is "bugged" again @damienen @icegriffinguru

BogdanCostinas commented 1 year ago

Internal Suggestion:

Marketplace--->My Data NFT

We can see which Data NFTs we listed but no other information eg. Listing price/ Listing Date Here also adding a button to change listing price could be usefull

BogdanCostinas commented 1 year ago

Community suggestion:

Filters on the marketplace I know you already have that in mind

Internal: Group the Data NFTs listed on Marketplace based on the Creator/ Owner Add a Hyperlink to open a new page for a specific creator/owner on the marketplace (Clicking on XYZ's Data NFT to be able to see all the datasets listed by XYZ )

Not urgent, just something that i had in mind

BogdanCostinas commented 1 year ago

Community suggestion:

The description is limited to 250 characters, can we increase the limit?

BogdanCostinas commented 1 year ago

Praveen( Internal )

Describe the bug Can't enter a custom number for % via the number pad on the keyboard. The number of copies I can use the keyboard but cant delete the first number it only lets me delete the second and third number.

To Reproduce In the trade data screen not possible to use the number pad to enter a custom % for the Royalties, have to only use the up and down arrows. The number of copies the numpad partially works.

Expected behavior Not sure if this is an intended design to have figures only increment/decrement by 5%? Copies also should permit a fully typed number.

Device used: Laptop Browser Version: eg: Brave (Latest) OS: Windows 11

Phone : Android with Maiar App

BogdanCostinas commented 1 year ago

Internal Suggestion Highlighted Tab is usually the active tab, on our Data DEX is other way around

Check the screenshot below 1) active tab 2) inactive tab

Can we highlight the active tab and give a gray nuance to the inactive ones?

BogdanCostinas commented 1 year ago

Internal:

Description: Try to add some extra characters ( Numbers ) into the price field, and keep doing this until the price reset to 0

Steps to reproduce Step 1) Mint a data NFT ( if you don't own one ) / Buy one from the Marketplace Stept 2) Go to Wallet Step 3) In the "Price" section keep adding numbers ( eg keep on adding 7) Step 4 ) Get the bug ( after the e217 the price gets to 0

Expected behavior: Price to be set to maximum Circulating supply/ Total supply

BogdanCostinas commented 1 year ago

Internal ( Praveen )

Describe the bug Setting price to 9999 (it seems to permit huge numbers and goes into e+, need to limit the max number here) and 20 results in the attached message after signing the TX.

Expected behavior Smaller numbers for the price seem to be OK but larger numbers have an error.

Try with 999999 and it will result in a failed tx

Device used: Laptop Browser Version: eg: Brave (Latest) OS: Windows 11

BogdanCostinas commented 1 year ago

Community: Description : While Claiming from Claims Portal or Faucet you're not able to see your Data NFTs

Step 1- Claim from allocation/reward/airdrop Step 2 - Sign the TX Step 3 - While waiting for the transaction to be completed, go to Wallet Step4 - Receive the Error

Expected Behavior: No matter what i am doing, my Data NFT wallet should be visible

BogdanCostinas commented 1 year ago

Community:

Description: While procuring 1 Data NFT, imedtiatlly after signing the TX go to "MY DATA NFTs" and you are able to see all other Data NFT's listed on Marketplace but with one BIG difference. All appear as yours and you can see a " Delist" button, and you can interact with that ( TX fail )

Step1- Go to Data NFT Marketplace Step2 - Procure 1 Data NFT Step3 -Quickly swap the pages to "My Data NFT" Step4 -The visual bug appear

Expected behavior - When i click on the My data nft page after signing the tx to procure 1 Data NFT it's supposed to display my own data NFTs, not the ones listed on marketplace with a delist option

BogdanCostinas commented 1 year ago

Suggestion:

Add the "OFFER" button

More context: I'm watching through Data NFTs Marketplace and I see something that I want to procure, but the price might be too spicy, maybe I can offer a lower amount for that particular Data NFT

Add "Bundle"

Maybe I want to trade 5-6 different datasets but I want to trade them in one pack

BogdanCostinas commented 1 year ago

Community ( Personally i cannot confirm it, tried with a mobile version with Android, and works ok with my phone, maybe other phones with get this )

Description: After successfully signing a transaction you get a message, that the transaction is going through. If you go to Advertise data and click on the Data Stream URL or another field, everything will be zoomed in and you cannot close the transaction message. On this point zooming out won't work

Step 1) Claim Faucet Tokens Step 2) Go to Advertise data Step 3) Click on Data stream URL field Step 4 ) Get the error

Expected behavior: TX message to be closed automatically or, not to zoom in after clicking on the Data Stream field

See more details in the pics attached: Pic1 before clicking on Data Stream URL Pic 2 After clicking on Data Stream URL

BogdanCostinas commented 1 year ago

Community:

Description: Trying to burn NFTs, if you try to delete the numbers from the keyboard is not working properly, automatically gives you the error that the amount cannot be 0

To reproduce Step1) Go to your Wallet Step2 ) selected one Data NFT Step 3) Click on Burn Step 4) in the How many do you want to burn area try to delete the preset number 1 and get the error. The same thing applies if you already change to another number, eg 9 and you try to delete

Internal suggestion If I try to delete the number written in the box, and it goes to 0, then the burn button is deactivated ( Change it's color too, make it red, until you choose a number higher than 1 and lower than the total supply owned )

BogdanCostinas commented 1 year ago

Community observation:

My testing process made me think about the burn option from the perspective of permissions and behavior: so in my tests, I did not mint my own NFT, I bought licenses from the public marketplace and could burn them if I wanted to. To an extreme, I could have purchased all 10 licenses, burnt them all, and made a product that was not minted by me disappear completely. I understand I bought a fully transferable product, but I am not sure I should be able to burn something I did not mint

BogdanCostinas commented 1 year ago

Community:

Description: Listing an NFT disappears from the wallet, it cannot be found under the Public Marketplace, either under My Data NFT from the Marketplace page

Step1) Buy/Mint 1 data NFT Step2) List your newly created/procured Data NFT Step3) Check the Public Marketplace/ My data NFTs and the Data NFTs are not there

Additional context, on the Marketplace there are only 2 Data NFTs on sale

Expected behavior: Checking on the Data NFT Marketplace or My Data NFT section I expect to be able to see my fresh listed Data NFT Same behavior using multiple types of wallets/ browsers

Itheum / data-dex

Data NFT Minting - Private Beta Testing Bugs and Issues. [🎉 = fixed, 👍 = looking into, 👀 = suggestion/not high priority but will be looked into] #150

suggestion :

Feature : Tagging

Suggestion :

Feature : Request for dataset with bounty

Cosmetic suggestion :