Closed damienen closed 1 year ago
Fair enough for me
Implemented #360
Cool. Closing.
@damienen @bucurdavid SC change has removed the check for other URLs. This is wrong.
This should ONLY apply to Data Stream URL. reopening
Changed only to Data Stream URL
@newbreedofgeek Please update SC
This has been solved. Closing
Issue with minting long URL seen again
This is due to title
or description
being too long.
require!(title.len() <= 30, ERR_TOO_MANY_CHARS);
require!(description.len() <= 400, ERR_TOO_MANY_CHARS);
Current implementation:
30 chars
400 chars
Maybe FE didn't catch the title length. @damienen
Yes here is a problem in FE, the validation was for 50 max chars for title. I will fix the validator there.
Solved. Closing.
As it is encrypted it is often very long, but the unencrypted value is not so big. This change should probably be moved into the data marshal (it is also already implemented in FE). This causes issues such as these:
https://devnet-explorer.multiversx.com/transactions/3cbbecc15b949fa5887c80df9f7def55a428d71932109eb30ac3f7f5aab32aab#smart
The normal URL was around 150 chars, but the encrypted one is 320 so the mint fails.