Itheum / data-dex

DApp with suite of web3 tools to trade personal data on MultiversX
https://datadex.itheum.io
GNU General Public License v3.0
463 stars 6 forks source link

Implement Web Wallet signatures work for Data Marshal (like other wallets) #532

Closed newbreedofgeek closed 1 year ago

newbreedofgeek commented 1 year ago

As @bucurdavid suggested.

By the way another workaround that came to my mind with the web wallet is using the SDK. But it’s not straightforward
Generating the marshal nonce
User copy the nonce, goes to web-wallet and sign
Come back and paste the nonce + signature
damienen commented 1 year ago

The login issue was solved.

But the signature was changed from string to buffer in the new version of sdk-core. I suggest we hold it off until after the BoY

damienen commented 1 year ago

Apparently the issue is still present in the MultiversX sdk-dapp library...

I have notified them. I will leave this open, but until then I have activated the Web Wallet login button so it can be used for claims on mainnet.

icegriffinguru commented 1 year ago

Implemented. one issue is that data marshal api is called twice because props of LowerCard changes many times

damienen commented 1 year ago

We need to prevent the file from loading twice (and modal loading twice)

damienen commented 1 year ago

Works. Closing. Nice job, @icegriffinguru !