MX Hub login stuck on devnet and seem to loop

Itheum / data-dex

DApp with suite of web3 tools to trade personal data on MultiversX

https://datadex.itheum.io

GNU General Public License v3.0

466 stars 6 forks source link

MX Hub login stuck on devnet and seem to loop #982

Closed newbreedofgeek closed 1 year ago

newbreedofgeek commented 1 year ago

@fuzzyduke raised this on 1.4 after testing yesterday. It's a blocker and @damienen issued a fix via https://github.com/Itheum/data-dex/pull/981#pullrequestreview-1612333715

Which is merged...

We need to test this properly to make sure something else did not break.

@fuzzyduke note that now when you login via XPortal, it wont redirect to "dashboard". which is fine for now... main thing is that it works

fuzzyduke commented 1 year ago

Tried to run a burn transaction with xportal. Upon signing in xportal, the below was seen. The sign dint seem to be acknowledged by the datadex.

@damienen @newbreedofgeek

Steps

connect to #859 using xportal.
Run a burn transaction on an item in the wallet.
Sign transaction in the wallet.

It is seen that no continuity is seen on the datadex after signing in the wallet.

Expected behaviour.

The transaction should have been processed and the count should have been reduced on the supply.

Note: This is not consistently reproduceable.

fuzzyduke commented 1 year ago

This was encountered while purchasing via xportal as well, after signing the transaction in the wallet, continuity was not seen on the datadex. This is again not consistently reproduceable as purchases are also seen to go through normally with xportal at times.

fuzzyduke commented 1 year ago

While attempting a second login to xportal the below is seen. Unsure of the impact of the message in the console.

Was able to scan the QR code and login using Xportal. However for a short period of time noticed the message "Invalid QR code" before it then successfully scanned the QR code and proceeded to successful login.

damienen commented 1 year ago

It's the xPortal hub login that needs testing, not the xPortal login...

fuzzyduke commented 1 year ago

Ok, will assume it is not connected in any way, and post these under a new ticket.

Kindly find below the behavior upon clearing cache and cookies.

It seems that the Balance is taken from devnet but shows mainnet.

Also periodically while clearing cookies and cache and reloading the log to that account is still observed, it is not showcased in the loom though.

https://www.loom.com/share/48bc7d2c2a5c4b8fb93136ed9da06a8b?sid=777d3c0f-4a00-4393-88d4-2428d953c9a5

damienen commented 1 year ago

Just dropped a fix for the mainnet/devnet balance: https://github.com/Itheum/data-dex/pull/983

fuzzyduke commented 1 year ago

Odd behaviour seen. Mainnet to devnet redirection observed.

1.Logged into xportal hub on mainnet.

Clicked on a data NFT. Seen that it was a 404.
Clicked on datadex and it sends me to devnet.

https://www.loom.com/share/7380f7eb162b435689fb4e50cfc4ff24?sid=211fda1d-487a-40c7-9e6d-1478a9114859

fuzzyduke commented 1 year ago

To add to the loom video.

When using defi wallet the same offer is seen on mainnet

But when using xportal hub, it says offer not found 404.

damienen commented 1 year ago

Dropped a fix for this one, too, in the same PR

fuzzyduke commented 1 year ago

Verified, fixed.

Upon reviewing, fixes commited on hub are reflecting. Transitions from mainnet to devnet are only seen when redirection is seen on new tab.

Generally for offers redirected to same tab the error of 404 seems to be resolved.

Balance mapping also seems stable at this point. That is, the mainet is showing mainnet ballance and not devnet balance.