Itheum / explorer-dapp

Itheum Explorer enables for the exploration of the Itheum protocol
GNU General Public License v3.0
457 stars 3 forks source link

Render PDF documents in Explorer #101

Open vmradulescu opened 11 months ago

vmradulescu commented 11 months ago

To support Andrew and further Integrators who will be minting multi page PDF documents as Data NFTs, a required upgrade to Explorer is needed in order to support PDF documents

Expectation:

View Data

PDF app marketplace

PDF Tool:

Dev testing:

https://devnet-explorer.multiversx.com/transactions/cddd58686c2e445c192f122b611cc87099561c03cee65ffdbdef59f29452df36#b292855a3cfed9834360249a8f5f996e98f387400d6f9d0bec138c15c858ddc9

https://stg.datadex.itheum.io/datanfts/marketplace/DATANFTFT4-3ba099-01dc/offer-2103

Possible tech options for PDF rendering:

Timeline: Product Spec creation: 11th of August PDF Data NFT's available: 11th of August Brief and assignment: 11th of August Development: 16-17th of August Final testing: 17th of August Deployment: 17th-18th of August

*Timeline may change based on Andrei's strategy.

damienen commented 11 months ago

Done. Moving to review

fuzzyduke commented 11 months ago

As per the current implementation seen for the above app, the 2 requirements are not met.

  1. The PDF should open in an inline view.
  2. Pagination should be accessible within the viewer for the PDF.

Currently it seems like the PDF alone is just opening in a new tab and as that is the case there is no app mechanism for pagination, just the normal PDF render in a browser window. image

Please clarify the implementation.

damienen commented 11 months ago

Talked with @newbreedofgeek about this and he gave the OK for this implementation. Also, pagination is available, you view the document page by page.

But best to do is to clarify that this is ok in the morning

On Mon, Aug 14, 2023, 9:24 PM Eddy @.***> wrote:

As per the current implementation seen for the above app, the 2 requirements are not met.

  1. The PDF should open in an inline view.
  2. Pagination should be accessible within the viewer for the PDF.

Currently it seems like the PDF alone is just opening in a new tab and as that is the case there is no app mechanism for pagination, just the normal PDF render in a browser window. [image: image] https://user-images.githubusercontent.com/121969933/260538857-84bc4f47-4b5c-451a-8644-266b8a692e76.png

Please clarify the implementation.

— Reply to this email directly, view it on GitHub https://github.com/Itheum/explorer-dapp/issues/101#issuecomment-1677855012, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKV4Z5QSUPBPNPZ6A73TPR3XVJUNHANCNFSM6AAAAAA3MOJYDM . You are receiving this because you were assigned.Message ID: @.***>

vmradulescu commented 11 months ago

Checked the current implementation:

Let's clarify in the morning regarding on how the opening of the pdf should be handled. As in my view, right now we are opening it in a new tab and using the browser's pdf viewer, which would mean that there isnt actually a need for an app for this, which might confuse users.

newbreedofgeek commented 11 months ago

We will do both:

  1. In Wallet View, we just open in a new tab
  2. In the App View, we will show a preview of the PDF with paging. And Also allow the user to open in a new tab so they can get the best UX with the browser's default PDF viewer

I've built this and preview link is coming soon

@vmradulescu @fuzzyduke @damienen