Itheum / explorer-dapp

Itheum Explorer enables for the exploration of the Itheum protocol
GNU General Public License v3.0
457 stars 3 forks source link

PH Support: AppsConfig for Data Widgets should support Data NFT-PH collections #372

Closed newbreedofgeek closed 2 months ago

newbreedofgeek commented 3 months ago

In data widgets like NF-Tunes, we support Data NFT (SFTs) in this format in appsConfig.tsx:

image

But, with Data NFT-PH collections, they wont be SFTs. We need the ability to add Data NFT-PH collection like this : https://devnet-explorer.multiversx.com/collections/OASMUSICPL-47b186/roles

we have to upgrade appsConfig.tsx to also show Data NFT-PH collections for data widgets.

damienen commented 3 months ago

Substeps needed on order to solve this:

damienen commented 3 months ago

When checking this issue look out for this:

  1. No loading time for NFTs when loading explorer.
  2. No bugs like "no nfts owned" in wallet and widgets
  3. Have NFT pagination in wallet and widgets
fuzzyduke commented 3 months ago
  1. Passed
  2. Fail - please check below. Appears for a brief period, can be simulated by refreshing the wallet.
  3. Pass

tested on pr

Image

fuzzyduke commented 2 months ago

Verified. Passed