Itheum / itheumcore-elrond-data-nft-marketplace

MuliversX blockchain Data NFT marketplace (Data Market)
0 stars 0 forks source link

New issue: Discount checks inverted #32

Closed damienen closed 1 year ago

damienen commented 1 year ago

The order of discount_fee_percentage_buyer and discount_fee_percentage_seller was inverted. Now the function checks that seller_fee >= discount_fee_percentage_buyer, and that buyer_fee >= discount_fee_percentage_seller. This could result in particular in the seller discount being greater than the seller fee, which would prevent all offers to be accepted on the marketplace.

damienen commented 1 year ago

Checked. Solved.