search

Itheum / sdk-mx-data-nft

TypeScript/JavaScript SDK for Itheum's Data NFT Technology on MultiversX Blockchain
https://itheum.github.io/sdk-mx-data-nft/
GNU General Public License v3.0
458 stars 3 forks source link

Allow for extra image in metadata and to move image preview out of traits #127

Closed newbreedofgeek closed 5 months ago

newbreedofgeek commented 5 months ago

To fix:

https://github.com/Itheum/sdk-mx-data-nft/issues/126

https://github.com/Itheum/sdk-mx-data-nft/issues/125

damienen commented 5 months ago

Preview can be moved out of traits, but it's debatable if it should be moved as it allows people to quickly see the preview from the marketplace.

The bonus image trait is redundant as we should just use the MultiversX NFT standard Screenshot_20240406-145302 That would mean actively using the assets URIs. Those can be however many we want, more cam be updated to make the NFTs upgradable, etc.

damienen commented 5 months ago

Here's some documentation on it: https://docs.multiversx.com/tokens/nft-tokens/#add-uris-to-nft

https://docs.multiversx.com/tokens/nft-tokens/#creation-of-an-nft see URIs at end of NFT creation

newbreedofgeek commented 5 months ago

that's fine, but we are going to aim to build this to be multi-chain compatible so we can bridge data nfts.

[UPDATE] But as per our discussions on the side, we will support BOTH adding to MvX NFT "Assets" and also on the NFT Metadata

newbreedofgeek commented 5 months ago

Looks good @damienen

Once confirmed to work via an alpha pubish on NPM and used by Data DEX, we can merge to develop.