Closed newbreedofgeek closed 5 months ago
nftMinter.initializeContract documentation seems incomplete.
e.g. claims address for royalties param is not appearing in the documentation for the params
nftMinter.initializeContract's mintLimit
param [(seconds)- The mint limit between mints ]- should this be called "secsBetweenMints"? or something that aligns better?
Does nftMinter.initializeContract have a MAX limit in the collection? ie. 10k. Is this needed?
I setup a new minter, but when I called initializeContract
I got a TX Success
, but onchain it seemed to fail as no token was issued. See this TX : https://devnet-explorer.multiversx.com/transactions/dca7412ded69fcff3f905b05d41ab46f017ba9c2ccc70891a4fc33dab6b67c7a#d938fb9558c4c62f36f5a5bf3b1fcb69e2eec4ab303e2b8c864db4c8062b711e
I then called await nftMinter.viewContractConfiguration();
, but I got the following error. Does this error make sense?
In the docs, for the nftMinter and sftMinter, for tokenName... just write the name of the Data NFT. Between 3 and 20 alphanumeric characters, no spaces.
in the docs, for nftMinter and sftMinter, the antiSpamTax is in different places. Need to align it, maybe the best is the pattern in nftMinter.
https://itheum.github.io/sdk-mx-data-nft/classes/SftMinter.html#mint https://itheum.github.io/sdk-mx-data-nft/classes/NftMinter.html#mint
in docs, for both the nft and sft minter we have "pauseCollection" and "unpauseCollection".
This is the "freeze" collection right? once we clarify, we need to update the docs to be more descriptive
in SDK, for both nt and sft minter, how do you remove someone from the whitelist?
If it's possible, we need to update docs and/or SDK to allow this.
on the SDK/docs,
With the successive updates to the SDK, it seems appropriate to consider this issue resolved. CC: @newbreedofgeek
closing
Some items to follow up and update... as observed when testing V2 via the SDK