Itheum / sdk-mx-data-nft

TypeScript/JavaScript SDK for Itheum's Data NFT Technology on MultiversX Blockchain
https://itheum.github.io/sdk-mx-data-nft/
GNU General Public License v3.0
458 stars 3 forks source link

v2 - updates and follows needed #55

Closed newbreedofgeek closed 5 months ago

newbreedofgeek commented 11 months ago

Some items to follow up and update... as observed when testing V2 via the SDK

newbreedofgeek commented 11 months ago

nftMinter.initializeContract documentation seems incomplete.

e.g. claims address for royalties param is not appearing in the documentation for the params

image
newbreedofgeek commented 11 months ago

nftMinter.initializeContract's mintLimit param [(seconds)- The mint limit between mints ]- should this be called "secsBetweenMints"? or something that aligns better?

newbreedofgeek commented 11 months ago

Does nftMinter.initializeContract have a MAX limit in the collection? ie. 10k. Is this needed?

newbreedofgeek commented 11 months ago
image
newbreedofgeek commented 11 months ago

In the docs, for the nftMinter and sftMinter, for tokenName... just write the name of the Data NFT. Between 3 and 20 alphanumeric characters, no spaces.

image
newbreedofgeek commented 11 months ago

in the docs, for nftMinter and sftMinter, the antiSpamTax is in different places. Need to align it, maybe the best is the pattern in nftMinter.

https://itheum.github.io/sdk-mx-data-nft/classes/SftMinter.html#mint https://itheum.github.io/sdk-mx-data-nft/classes/NftMinter.html#mint

image image
newbreedofgeek commented 11 months ago

in docs, for both the nft and sft minter we have "pauseCollection" and "unpauseCollection".

This is the "freeze" collection right? once we clarify, we need to update the docs to be more descriptive

image
newbreedofgeek commented 11 months ago

in SDK, for both nt and sft minter, how do you remove someone from the whitelist?

If it's possible, we need to update docs and/or SDK to allow this.

image
newbreedofgeek commented 11 months ago

on the SDK/docs,

image
bucurdavid commented 7 months ago

With the successive updates to the SDK, it seems appropriate to consider this issue resolved. CC: @newbreedofgeek

newbreedofgeek commented 5 months ago

closing