search

Itheum / sdk-mx-data-nft

TypeScript/JavaScript SDK for Itheum's Data NFT Technology on MultiversX Blockchain
https://itheum.github.io/sdk-mx-data-nft/
GNU General Public License v3.0
458 stars 3 forks source link

Roll out pepe's fix to Data NFT SDK #95

Closed newbreedofgeek closed 7 months ago

damienen commented 7 months ago

Fixed in this PR: https://github.com/Itheum/sdk-mx-data-nft/pull/92

damienen commented 7 months ago

The only thing that might be missing is allowing users to override the marshal as well if they want to.

damienen commented 7 months ago

One more thing as we discussed in DMs, @bucurdavid :

  1. Semantic bot push should happen on develop (and maybe create a PR towards main that we can manually approve? but this is not obligatory)
  2. Push to npm should be able to be done from main branch without doing a push to main
damienen commented 7 months ago

Alright. We will push out the semantic releasing and we will do just auto npm releases once some new commits goes to main

damienen commented 7 months ago

Solved. Closing.