search

Itiviti / gradle-msbuild-plugin

Gradle plugin for msbuild execution, supports C# project files for now
Apache License 2.0
101 stars 58 forks source link

Upgrading Gradle wrapper from 4.9 to 5.0 #104

Closed Thunderforge closed 5 years ago

Thunderforge commented 5 years ago

Upgrading to the latest version of the Gradle wrapper.

Note that before this change, gradle/wrapper/gradle-wrapper.jar was previously generated by Gradle 4.2 (see META-INF within the jar). This one is generated by Gradle 5.0.

Thunderforge commented 5 years ago

It looks like AppVeyor failed because NUnit wasn't installed? Is that an error on my end or AppVeyor's end?

gluck commented 5 years ago

The error seems to be:

Invalid cookie header: "Set-Cookie: has_recent_activity=1; path=/; expires=Mon, 26 Nov 2018 19:16:08 -0000". Invalid 'expires' attribute: Mon, 26 Nov 2018 19:16:08 -0000
Invalid cookie header: "Set-Cookie: logged_in=no; domain=.github.com; path=/; expires=Fri, 26 Nov 2038 18:16:08 -0000; secure; HttpOnly". Invalid 'expires' attribute: Fri, 26 Nov 2038 18:16:08 -0000

The closest I can find is https://github.com/gradle/gradle/issues/1596 It's fixed on gradle side (supposedly), but maybe we need to upgrade httpclient somewhere else ?

gluck commented 5 years ago

Actually I don't think we can upgrade gradle because of : https://github.com/bintray/gradle-bintray-plugin/issues/253

And we can't upgrade bintray plugin to 1.8.1 because it's not compatible w/ plugindev (which is deprecated but we haven't moved yet out of it ....)

Sorry ... :'(

Thunderforge commented 5 years ago

@gluck Too bad that we can't upgrade Gradle because of the Bintray plugin. I'll close this.

timotei commented 5 years ago

@gluck Can't we use another plugin like https://github.com/bintray/gradle-bintray-plugin ?

ngyukman commented 5 years ago

it is already gradle-bintray-plugin but the one not working is plugindev, which needs some refactoring to replace

ngyukman commented 5 years ago

https://github.com/etiennestuder/gradle-plugindev-plugin/issues/34

the issue has been solved