search

Itiviti / gradle-msbuild-plugin

Gradle plugin for msbuild execution, supports C# project files for now
Apache License 2.0
101 stars 57 forks source link

using : (instead =) for passing arguments to msbuild #36

Closed marcozwyssig closed 9 years ago

gluck commented 9 years ago

Not sure that's what @jonathanmorley had in mind when he pushed #25 . I don't use these extra properties myself, so I'll rely on your (agreed) point of view :smile:

gluck commented 9 years ago

Actually as far as both msbuild and xbuild, /X=Y doesn't seem useful outside of properties, which is already covered in the plugin (parameters).

jonathanmorley commented 9 years ago

As I mentioned in the readme, I have been using this for constructs such as ext["flp1:LogFile"] = file("${project.name}.errors.log").getPath() + ";ErrorsOnly;Verbosity=diag". Which now that I look at the msbuild docs again, seems semantically wrong.

They should be ext["flp1"] = "LogFile=" + file("${project.name}.errors.log").getPath() + ";ErrorsOnly;Verbosity=diag"

I'm ok with this, lets just change the readme to reflect these changes though

gluck commented 9 years ago

Thx you both ! I'll merge it and fix the doc