search

Itiviti / gradle-msbuild-plugin

Gradle plugin for msbuild execution, supports C# project files for now
Apache License 2.0
102 stars 57 forks source link

Use Evaluation.Project to parse project file #37

Closed adescamps-ullink closed 8 years ago

adescamps-ullink commented 9 years ago

Instead of using the deprecated Project class that is not compatible with the msbuild 4.0+ format, we use the non deprecated to allow parsing of all the new things introduce in the format like the Label on Import tag.

The parsing of the solution is done by internal class: SolutionParser A wrapper over all concerned classes has been created.

The serialization of the Solution still use the old method because the new parser don't give you all the information like the buildOrder.

pepijnve commented 8 years ago

I was getting parsing errors when using the plugin with VS2015 project files. With this PR merged the plugin works correctly again. Would be great if this could be integrated and released.

gluck commented 8 years ago

There's very little UTs for this part, this PR have to be tested against mono, even on windows I'm not confident it's backward compat with all the uses (though TBH I haven't tried, but I got feedback that the project list now included the solution with this change).

florian-gandon commented 8 years ago

+1 for more unit tests

gluck commented 8 years ago

I think we can drop this one in favor of #57 ?