Itiviti / gradle-msbuild-plugin

Gradle plugin for msbuild execution, supports C# project files for now
Apache License 2.0
102 stars 57 forks source link

Correctly handle Mono installed at 4.5-api #63

Closed eatdrinksleepcode closed 8 years ago

eatdrinksleepcode commented 8 years ago

Fixes #62

Note that the existing XBuildResolverTests will fail on a system with Mono 4.4.0 installed, but will not fail otherwise. I did not add an additional test that will always cover this scenario, even on systems with Mono 4.4.0, because doing so would have required a significant refactoring of the XBuildResolver class in order to be able to pass in test paths. If the maintainers would like that refactoring done and the test added, I am happy to do it.

I did notice that the existing tests did not cover the case of an explicitly specified version number, so I modified the existing "XBuildCanBeFound" test to also cover that case.

gluck commented 8 years ago

:+1: