search

Itiviti / gradle-msbuild-plugin

Gradle plugin for msbuild execution, supports C# project files for now
Apache License 2.0
101 stars 57 forks source link

Changed AssemblyInfoVersionPatcher so that it won't erase AssemblyDescription if no description is specified. #86

Closed LamarLugli closed 6 years ago

LamarLugli commented 6 years ago

Changed AssemblyInfoVersionPatcher so that it won't erase AssemblyDescription if no description is specified.

My solutions have multiple startup projects in them, and if we leave this in, it either overwrites the description to the same value, or it blanks out the description that already exists in the projects.

LamarLugli commented 6 years ago

This change works a bit better and allows "0" to be specified as the version number.

gluck commented 6 years ago

LGTM, would be great if you could update the CHANGELOG.md as well, otherwise I'll do it.

Thx!

LamarLugli commented 6 years ago

Thanks. I'll update CHANGELOG.md and add it to the pull request in the next hour.