search

Itiviti / gradle-nunit-plugin

A gradle plugin for launching NUnit tests
Apache License 2.0
17 stars 20 forks source link

Custom arguments and environment variables. #33

Closed panekzogen closed 7 years ago

panekzogen commented 8 years ago

Added possibility to set custom arguments and environment variables.

One bug fixed: https://github.com/michel-kraemer/gradle-download-task/issues/47

qliklars commented 8 years ago

Is there a reason for closing but nor merging this PR? We are very interested in the environment variable support that is added in this PR. Is there any easy workaround with the current plugin?

timotei commented 8 years ago

Sorry for the delay on reviewing this :(

First of all, thanks for the contribution!

For the custom extra arguments, are there any specific ones? Maybe we should add them as properties in the plugin itself instead.

panekzogen commented 8 years ago

Reasons for closing this PR:

panekzogen commented 8 years ago

I'm interesting in /labels /noshadow /nologo /timeout /output and /xml without prefix. But in my opinion adding extra arguments field is more flexible solution.

timotei commented 8 years ago

:+1: from me

gluck commented 8 years ago

I'm not fond of generic pass-through variables, as it defeats the purpose of having a plugin in the first place (if all you want is write the nunit command-line yourself, nothing will do a better job as using an Exec task directly). For the options you mention, labels/noshadow/timeout/xml are already available, I'd say that nologo should be set by default, so only /output remains. An option could be added, though the common practice (to my knowledge) is to have UT text report in your build log rather than a separate file.

I assume these options come from migrating from a script build approach ?

gluck commented 8 years ago

(note that I upgraded gradle/download/httpclient on master and released 1.9 with it, should fix gradle-related issues)

qliklars commented 8 years ago

@gluck : What about the env var support? We are passing environment variables that control the placement of test artifacts in prebuilt C# test assemblies. Do you have a suggestion for them?

gluck commented 8 years ago

Totally okay with that one, I missed the fact it was your pain point or I would have included it in the earlier release sorry. Feel free to PR just that

panekzogen commented 8 years ago

Yes these options from migration. Finally i added output option and env variables. From my point of view output option will not be superfluous.

timotei commented 7 years ago

Btw, you should rebase against latest changes, seems there are some conflicts on README.md

panekzogen commented 7 years ago

Environment method is based on Map.putAll(). That's why empty env does not change execution, but null causes NullPointerException. I fixed it. Integration crashes on nunit 3.5 test. What will we do about it? Sorry for a delay.

panekzogen commented 7 years ago

Why don't you merge the request?

kuniss commented 7 years ago

When do you plan to merge this pull request? I'm also interested in having the possibility to define environment variables...

BTW, great work! Thank you for the Ullink Gradle plugins!

gluck commented 7 years ago

Long overdue, sorry !

kuniss commented 7 years ago

Great! Thanks!

I guess some one needs to push a release? Version 1.11 is not released yet on plugins.gradle.org ...

Or is on the way? Did not see it on AppVeyor nor Travis.

ngyukman commented 7 years ago

will do a release once the fix for #42 is ready, thanks for patient

kuniss commented 7 years ago

@ngyukman I saw the release 1.11 is done on GitHub. Thank you! When do you plan to publish it to https://plugins.gradle.org/plugin/com.ullink.nunit?

ngyukman commented 7 years ago

@kuniss sorry that we are having some problem with the release in https://plugins.gradle.org/ but you can reference to the maven repo https://bintray.com/ullink/gradle-plugins/com.ullink.gradle:gradle-nunit-plugin for now, we will fix it once we have resolved the release issue

kuniss commented 7 years ago

No problem!

I will wait or use the repo dependency.

Thank you, for coming back with a note!

Am 13.07.2017 um 11:42 schrieb Ng Yuk Man:

@kuniss https://github.com/kuniss sorry that we are having some problem with the release in https://plugins.gradle.org/ but you can reference to the maven repo https://bintray.com/ullink/gradle-plugins/com.ullink.gradle:gradle-nunit-plugin for now, we will fix it once we have resolved the release issue

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Ullink/gradle-nunit-plugin/pull/33#issuecomment-315028250, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDoA_i48sEELrYLJG5f9IpxjTpzYb5Tks5sNeafgaJpZM4J1oO0.