Closed panekzogen closed 7 years ago
Is there a reason for closing but nor merging this PR? We are very interested in the environment variable support that is added in this PR. Is there any easy workaround with the current plugin?
Sorry for the delay on reviewing this :(
First of all, thanks for the contribution!
For the custom extra arguments, are there any specific ones? Maybe we should add them as properties in the plugin itself instead.
Reasons for closing this PR:
I'm interesting in /labels /noshadow /nologo /timeout /output
and /xml
without prefix. But in my opinion adding extra arguments field is more flexible solution.
:+1: from me
I'm not fond of generic pass-through variables, as it defeats the purpose of having a plugin in the first place (if all you want is write the nunit command-line yourself, nothing will do a better job as using an Exec
task directly).
For the options you mention, labels/noshadow/timeout/xml are already available, I'd say that nologo should be set by default, so only /output remains. An option could be added, though the common practice (to my knowledge) is to have UT text report in your build log rather than a separate file.
I assume these options come from migrating from a script build approach ?
(note that I upgraded gradle/download/httpclient on master and released 1.9 with it, should fix gradle-related issues)
@gluck : What about the env var support? We are passing environment variables that control the placement of test artifacts in prebuilt C# test assemblies. Do you have a suggestion for them?
Totally okay with that one, I missed the fact it was your pain point or I would have included it in the earlier release sorry. Feel free to PR just that
Yes these options from migration. Finally i added output option and env variables. From my point of view output option will not be superfluous.
Btw, you should rebase against latest changes, seems there are some conflicts on README.md
Environment method is based on Map.putAll(). That's why empty env does not change execution, but null causes NullPointerException. I fixed it. Integration crashes on nunit 3.5 test. What will we do about it? Sorry for a delay.
Why don't you merge the request?
When do you plan to merge this pull request? I'm also interested in having the possibility to define environment variables...
BTW, great work! Thank you for the Ullink Gradle plugins!
Long overdue, sorry !
Great! Thanks!
I guess some one needs to push a release? Version 1.11 is not released yet on plugins.gradle.org ...
Or is on the way? Did not see it on AppVeyor nor Travis.
will do a release once the fix for #42 is ready, thanks for patient
@ngyukman I saw the release 1.11 is done on GitHub. Thank you! When do you plan to publish it to https://plugins.gradle.org/plugin/com.ullink.nunit?
@kuniss sorry that we are having some problem with the release in https://plugins.gradle.org/ but you can reference to the maven repo https://bintray.com/ullink/gradle-plugins/com.ullink.gradle:gradle-nunit-plugin for now, we will fix it once we have resolved the release issue
No problem!
I will wait or use the repo dependency.
Thank you, for coming back with a note!
Am 13.07.2017 um 11:42 schrieb Ng Yuk Man:
@kuniss https://github.com/kuniss sorry that we are having some problem with the release in https://plugins.gradle.org/ but you can reference to the maven repo https://bintray.com/ullink/gradle-plugins/com.ullink.gradle:gradle-nunit-plugin for now, we will fix it once we have resolved the release issue
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Ullink/gradle-nunit-plugin/pull/33#issuecomment-315028250, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDoA_i48sEELrYLJG5f9IpxjTpzYb5Tks5sNeafgaJpZM4J1oO0.
Added possibility to set custom arguments and environment variables.
One bug fixed: https://github.com/michel-kraemer/gradle-download-task/issues/47