Its-Haze / league-rpc

Just a better Rich Presence for League of Legends. Showcasing Live Game Stats, Summoner Icons, Rank Emblems and Champion Skins on Discord.
GNU General Public License v3.0
28 stars 6 forks source link

Discord RPC Showing is wrong if the game's language is not English #17

Closed lucario387 closed 10 months ago

lucario387 commented 10 months ago

I played on Japanese Server and with Japanese Language, and if I used league-rpc-linux, the champion's icon display is not working, as it's searching for an image of a champion with Japanese name and not English.

Reproduce steps:

Its-Haze commented 10 months ago

Hi. thanks for reporting this issue. I will try to reproduce it tomorrow and see if i can figure out a solution.

Its-Haze commented 10 months ago

Hi @lucario387 .

I have now fixed the issue. please update to v1.0.1 and test it out.

https://github.com/Its-Haze/league-rpc-linux/releases/tag/v1.0.1

lucario387 commented 10 months ago
Traceback (most recent call last):
  File "league_rpc_linux/__main__.py", line 6, in <module>
ModuleNotFoundError: No module named 'nest_asyncio'
[80597] Failed to execute script '__main__' due to unhandled exception!

I'll try to re-download league-rpc-linux then reply again

Its-Haze commented 10 months ago

You have to install the new dependencies in requirements.txt into your virtual environment if you are using one

Its-Haze commented 10 months ago

So just run pip install -r requirements.txt

Or install the executable from the releases page

lucario387 commented 10 months ago

Very sorry for the late response. But now it works as intended. Tysm for the fix

Its-Haze commented 10 months ago

Very sorry for the late response. But now it works as intended. Tysm for the fix

Glad to hear!!